Differential D19111

Have ShareFileItemAction provide an output or an error if they are provided
ClosedPublic
Actions

Authored by apol on Feb 18 2019, 2:54 AM.

Details

Reviewers
nicolasfella
Group Reviewers
Dolphin
Frameworks
Commits
R495:a6d93ff28f09: Have ShareFileItemAction provide an output or an error if they are provided
Summary

BUG: 397567

Test Plan

Manual testing on dolphin

Diff Detail

Repository
R495 Purpose Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8637
Build 8655: arc lint + arc unit
apol created this revision.Feb 18 2019, 2:54 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 18 2019, 2:54 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Feb 18 2019, 2:54 AM
ngraham added a subscriber: ngraham.Feb 18 2019, 2:59 PM
ngraham added inline comments.
src/widgets/menu.cpp
84 ↗(On Diff #51940)

Is this necessary? If so, maybe it should have a more descriptive string...

apol updated this revision to Diff 52218.Feb 21 2019, 4:45 PM

Remove unrelated debug info

nicolasfella accepted this revision.Feb 21 2019, 4:55 PM
nicolasfella added inline comments.
src/fileitemactionplugin/CMakeLists.txt
3

Maybe move the check to the parent CMakeLists.txt and include fileitemactionplugin conditionally?

This revision is now accepted and ready to land.Feb 21 2019, 4:55 PM
apol closed this revision.Feb 21 2019, 5:01 PM

Landed, don't know why this didn't update.

Revision Contents
Changeset List

Diff 52218

View Options

src/fileitemactionplugin/CMakeLists.txt

Loading...
View Options

src/fileitemactionplugin/sharefileitemaction.cpp

Loading...
View Options

src/widgets/menu.h

Loading...