Differential D19108

[ExternalExtractor] Provide more helpful output when extractor fails
ClosedPublic
Actions

Authored by bruns on Feb 17 2019, 11:43 PM.

Details

Reviewers
ngraham
poboiko
astippich
lbeltrame
Group Reviewers
Baloo
Frameworks
Commits
R286:36dafc3cb668: [ExternalExtractor] Provide more helpful output when extractor fails
Summary

In case the executable fails to start, no error was given at all.
Show the pluginpath if no manifest.json is found.
Show the extractor path and indexed file when the extractor fails at
runtime.

Test Plan

ctest

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Feb 17 2019, 11:43 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFeb 17 2019, 11:43 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Feb 17 2019, 11:43 PM
lbeltrame accepted this revision.Feb 18 2019, 6:14 AM
lbeltrame added a subscriber: lbeltrame.

LGTM!. Annoyed me for a long time (and made hard to debug some issues).

src/externalextractor.cpp
120

Will this block anything?

This revision is now accepted and ready to land.Feb 18 2019, 6:14 AM
Closed by commit R286:36dafc3cb668: [ExternalExtractor] Provide more helpful output when extractor fails (authored by bruns). · Explain WhyFeb 18 2019, 2:16 PM
This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.Feb 18 2019, 2:19 PM
bruns added inline comments.
src/externalextractor.cpp
120

At most 3 seconds (non gui task), also see the waitforfinished below ...

Revision Contents
Changeset List

PathPackages
Msrc/externalextractor.cpp (14 lines)

Diff 51965

View Options

src/externalextractor.cpp

Loading...