Differential D19054

Port cross-compilation support to KF5_HOST_TOOLING
ClosedPublic
Actions

Authored by vkrause on Feb 15 2019, 9:07 PM.

Details

Reviewers
apol
Commits
R238:d6ccdc0fff46: Port cross-compilation support to KF5_HOST_TOOLING
Summary

This is more consistent with this is done in other frameworks, and more
importantly it works in more scenarios. The old approach here was failing
when target executables were also found, in which case their CMake targets
had both LOCATION (pointing to target executables) and IMPORTED_LOCATION
(pointing to native executables) properties set.

Diff Detail

Repository
R238 KDocTools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Feb 15 2019, 9:07 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptFeb 15 2019, 9:07 PM
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Feb 15 2019, 9:07 PM
ltoscano added subscribers: habacker, ltoscano.Feb 15 2019, 9:52 PM

I trust @vkrause that this complicated part works, but I need to ask @habacker too, as he contributed part of the cross-compiling code.

If anyone else from the Windows project would like to comment to, that would be nice.

apol accepted this revision.Feb 16 2019, 12:46 AM
apol added a subscriber: apol.

Thanks!

This revision is now accepted and ready to land.Feb 16 2019, 12:46 AM
vkrause added a comment.Feb 16 2019, 9:46 AM
In D19054#413147, @ltoscano wrote:

I trust @vkrause that this complicated part works, but I need to ask @habacker too, as he contributed part of the cross-compiling code.

If anyone else from the Windows project would like to comment to, that would be nice.

Right. The idea is that the old approach keeps working as before, if KF5_HOST_TOOLING is not defined.

Closed by commit R238:d6ccdc0fff46: Port cross-compilation support to KF5_HOST_TOOLING (authored by vkrause). · Explain WhyFeb 23 2019, 8:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
MKF5DocToolsConfig.cmake.in (34 lines)
Msrc/CMakeLists.txt (6 lines)

Diff 52360

View Options

CMakeLists.txt

Loading...
View Options

KF5DocToolsConfig.cmake.in

Loading...
View Options

src/CMakeLists.txt

Loading...