Differential D19047

[GridDelegate] Fix long labels blending into each other
ClosedPublic
Actions

Authored by filipf on Feb 15 2019, 6:36 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
VDG
Commits
R296:23942e570831: [GridDelegate] Fix long labels blending into each other
Summary

This patch anchors the GridDelegate's label width and height to the thumbnail, as opposed to the parent.

BUG: 404389
FIXED-IN: 5.56

Test Plan

Before:

After:

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Feb 15 2019, 6:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 15 2019, 6:36 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
filipf requested review of this revision.Feb 15 2019, 6:36 PM
filipf edited the summary of this revision. (Show Details)Feb 15 2019, 6:37 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Frameworks, ngraham, VDG.
ngraham accepted this revision.Feb 15 2019, 6:47 PM

+1, definitely the correct fix.

Let's land this now and then we can work on the UI improvement of enabling multi-line strings in another patch.

This revision is now accepted and ready to land.Feb 15 2019, 6:47 PM
filipf edited the summary of this revision. (Show Details)Feb 15 2019, 6:53 PM
In D19047#413025, @ngraham wrote:

+1, definitely the correct fix.

Let's land this now and then we can work on the UI improvement of enabling multi-line strings in another patch.

Okay! :)

Closed by commit R296:23942e570831: [GridDelegate] Fix long labels blending into each other (authored by filipf, committed by ngraham). · Explain WhyFeb 15 2019, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51792

View Options

src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

Loading...