Fix build with cmake 3.5
ClosedPublic

Authored by wbauer on Feb 12 2019, 6:59 AM.

Details

Summary

VERSION_GREATER_EQUAL requires cmake 3.7 or higher.
So use NOT VERSION_LESS instead, which is logically equivalent and also works with older cmake versions.

Test Plan

Builds fine with cmake 3.5.2 now.
Before, I got this cmake error:

CMake Error at src/extractors/CMakeLists.txt:39 (if):
  if given arguments:

    "0.25" "VERSION_GREATER_EQUAL" "0.26"

  Unknown arguments specified

HAVE_WEBP_SUPPORT is still defined when building with exiv2 0.26 or 0.27, and it is not defined with 0.25.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer created this revision.Feb 12 2019, 6:59 AM
Restricted Application added a project: Baloo. · View Herald TranscriptFeb 12 2019, 6:59 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
wbauer requested review of this revision.Feb 12 2019, 6:59 AM
wbauer edited the test plan for this revision. (Show Details)Feb 12 2019, 7:12 AM
wbauer edited the summary of this revision. (Show Details)Feb 12 2019, 7:17 AM
lbeltrame added a reviewer: bruns.
krop accepted this revision.Feb 12 2019, 9:13 AM
This revision is now accepted and ready to land.Feb 12 2019, 9:13 AM
This revision was automatically updated to reflect the committed changes.