Remove conditional debug output
ClosedPublic

Authored by tcanabrava on Mon, Feb 11, 5:05 PM.

Details

Summary

We can control that via a configuration file, having to re-compile
just to see new debug output is quite annoying.

Diff Detail

Repository
R374 KolourPaint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava requested review of this revision.Mon, Feb 11, 5:05 PM
tcanabrava created this revision.
patrickelectric added inline comments.
commands/imagelib/transforms/kpTransformResizeScaleCommand.cpp
255–256

Are this endl necessaries since you are using qCDebug ?

They aren’t, just forgot to remove all of them

Em ter, 12 de fev de 2019 às 16:54, patrick j pereira <
noreply@phabricator.kde.org> escreveu:

patrickelectric added inline comments. View Revision
https://phabricator.kde.org/D18930
*INLINE COMMENTS*
View Inline https://phabricator.kde.org/D18930#inline-105485
kpTransformResizeScaleCommand.cpp:256
<< " newHeight=" << m_newHeight
<< endl;
#endif

Are this endl necessaries since you are using qCDebug ?

*REPOSITORY*
R374 KolourPaint

*REVISION DETAIL*
https://phabricator.kde.org/D18930

*To: *tcanabrava, broulik
*Cc: *patrickelectric

tcanabrava updated this revision to Diff 51681.Thu, Feb 14, 2:21 PM
  • Fix compilation
broulik accepted this revision.Thu, Feb 14, 2:34 PM

Please fix the warnings this now causes separately

This revision is now accepted and ready to land.Thu, Feb 14, 2:34 PM
This revision was automatically updated to reflect the committed changes.