patrickelectric added inline comments. View Revision
https://phabricator.kde.org/D18930
*INLINE COMMENTS*
View Inline https://phabricator.kde.org/D18930#inline-105485
kpTransformResizeScaleCommand.cpp:256
<< " newHeight=" << m_newHeight
<< endl;
#endif

Are this endl necessaries since you are using qCDebug ?

*REPOSITORY*
R374 KolourPaint

*REVISION DETAIL*
https://phabricator.kde.org/D18930

*To: *tcanabrava, broulik
*Cc: *patrickelectric

Fix compilation

Harbormaster completed remote builds in B8291: Diff 51681.Feb 14 2019, 2:21 PM

Please fix the warnings this now causes separately

This revision is now accepted and ready to land.Feb 14 2019, 2:34 PM

Closed by commit R374:fff60307ff06: Remove conditional debug output (authored by tcanabrava). · Explain WhyFeb 14 2019, 2:39 PM

This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 102 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

			Path	Packages
M			commands/imagelib/transforms/kpTransformResizeScaleCommand.cpp (4 lines)
M			commands/kpCommandHistory.cpp (5 lines)
M			commands/kpCommandHistoryBase.cpp (78 lines)
M			commands/kpCommandSize.cpp (11 lines)
M			commands/kpMacroCommand.cpp (17 lines)
M			commands/tools/flow/kpToolFlowCommand.cpp (5 lines)
M			commands/tools/kpToolFloodFillCommand.cpp (6 lines)
M			commands/tools/selection/kpToolImageSelectionTransparencyCommand.cpp (4 lines)
M			commands/tools/selection/kpToolSelectionCreateCommand.cpp (4 lines)
M			commands/tools/selection/kpToolSelectionDestroyCommand.cpp (10 lines)
M			commands/tools/selection/kpToolSelectionMoveCommand.cpp (10 lines)
M			commands/tools/selection/kpToolSelectionPullFromDocumentCommand.cpp (6 lines)
M			commands/tools/selection/kpToolSelectionResizeScaleCommand.cpp (4 lines)
M			commands/tools/selection/text/kpToolTextChangeStyleCommand.cpp (4 lines)
M			commands/tools/selection/text/kpToolTextGiveContentCommand.cpp (6 lines)
M			cursors/kpCursorLightCross.cpp (2 lines)
M			dialogs/imagelib/effects/kpEffectsDialog.cpp (41 lines)
M			dialogs/imagelib/kpDocumentMetaInfoDialog.cpp (39 lines)
M			dialogs/imagelib/transforms/kpTransformPreviewDialog.cpp (34 lines)
M			dialogs/imagelib/transforms/kpTransformResizeScaleDialog.cpp (16 lines)
M			dialogs/kpDocumentSaveOptionsPreviewDialog.cpp (20 lines)
M			document/kpDocument.cpp (8 lines)
M			document/kpDocumentSaveOptions.cpp (4 lines)
M			document/kpDocument_Open.cpp (10 lines)
M			document/kpDocument_Save.cpp (55 lines)
M			document/kpDocument_Selection.cpp (12 lines)
M			environments/document/kpDocumentEnvironment.cpp (21 lines)
M			generic/widgets/kpResizeSignallingLabel.cpp (7 lines)
M			imagelib/effects/kpEffectBalance.cpp (21 lines)
M			imagelib/effects/kpEffectBlurSharpen.cpp (20 lines)
M			imagelib/effects/kpEffectEmboss.cpp (5 lines)
M			imagelib/effects/kpEffectInvert.cpp (2 lines)
M			imagelib/effects/kpEffectReduceColors.cpp (21 lines)
M			imagelib/kpColor.cpp (6 lines)
M			imagelib/kpFloodFill.cpp (22 lines)
M			imagelib/kpPainter.cpp (65 lines)
M			imagelib/transforms/kpTransformAutoCrop.cpp (21 lines)
M			imagelib/transforms/kpTransformCrop_ImageSelection.cpp (24 lines)
M			imagelib/transforms/kpTransformCrop_TextSelection.cpp (5 lines)
M			layers/selections/image/kpAbstractImageSelection.cpp (38 lines)
M			layers/selections/image/kpFreeFormImageSelection.cpp (6 lines)
M			layers/selections/image/kpImageSelectionTransparency.cpp (17 lines)
M			lgpl/CMakeLists.txt (1 line)
M			lgpl/generic/kpColorCollection.cpp (26 lines)
M			lgpl/generic/widgets/kpColorCellsBase.cpp (20 lines)
M			mainWindow/kpMainWindow.cpp (52 lines)
M			mainWindow/kpMainWindow_Colors.cpp (10 lines)
M			mainWindow/kpMainWindow_Edit.cpp (44 lines)
M			mainWindow/kpMainWindow_File.cpp (91 lines)
M			mainWindow/kpMainWindow_Image.cpp (4 lines)
M			mainWindow/kpMainWindow_Settings.cpp (4 lines)
M			mainWindow/kpMainWindow_StatusBar.cpp (26 lines)
M			mainWindow/kpMainWindow_Text.cpp (19 lines)
M			mainWindow/kpMainWindow_Tools.cpp (22 lines)
M			mainWindow/kpMainWindow_View.cpp (6 lines)
M			mainWindow/kpMainWindow_View_Thumbnail.cpp (54 lines)
M			mainWindow/kpMainWindow_View_Zoom.cpp (52 lines)
M			pixmapfx/kpPixmapFX_DrawShapes.cpp (4 lines)
M			pixmapfx/kpPixmapFX_GetSetPixmapParts.cpp (2 lines)
M			pixmapfx/kpPixmapFX_Transforms.cpp (57 lines)
M			tools/flow/kpToolColorEraser.cpp (8 lines)
M			tools/flow/kpToolEraser.cpp (3 lines)
M			tools/flow/kpToolFlowBase.cpp (17 lines)
M			tools/flow/kpToolSpraycan.cpp (18 lines)
M			tools/kpToolColorPicker.cpp (2 lines)
M			tools/kpToolFloodFill.cpp (4 lines)
M			tools/kpToolZoom.cpp (11 lines)
M			tools/kpTool_Drawing.cpp (16 lines)
M			tools/kpTool_KeyboardEvents.cpp (42 lines)
M			tools/kpTool_MouseEvents.cpp (41 lines)
M			tools/kpTool_OtherEvents.cpp (22 lines)
M			tools/kpTool_Utilities.cpp (33 lines)
M			tools/polygonal/kpToolCurve.cpp (4 lines)
M			tools/polygonal/kpToolLine.cpp (4 lines)
M			tools/polygonal/kpToolPolygon.cpp (9 lines)
M			tools/polygonal/kpToolPolygonalBase.cpp (27 lines)
M			tools/rectangular/kpToolRectangularBase.cpp (11 lines)
M			views/kpThumbnailView.cpp (10 lines)
M			views/kpUnzoomedThumbnailView.cpp (18 lines)
M			views/kpView.cpp (25 lines)
M			views/kpView_Events.cpp (50 lines)
M			views/kpView_Paint.cpp (82 lines)
M			views/kpView_Selections.cpp (35 lines)
M			views/kpZoomedThumbnailView.cpp (22 lines)
M			views/kpZoomedView.cpp (12 lines)
M			views/manager/kpViewManager.cpp (15 lines)
M			views/manager/kpViewManager_TextCursor.cpp (6 lines)
M			views/manager/kpViewManager_ViewUpdates.cpp (33 lines)
M			widgets/colorSimilarity/kpColorSimilarityCubeRenderer.cpp (11 lines)
M			widgets/colorSimilarity/kpColorSimilarityToolBarItem.cpp (26 lines)
M			widgets/imagelib/effects/kpEffectBlurSharpenWidget.cpp (6 lines)
M			widgets/imagelib/effects/kpEffectFlattenWidget.cpp (9 lines)
M			widgets/imagelib/effects/kpEffectInvertWidget.cpp (7 lines)
M			widgets/kpColorCells.cpp (16 lines)
M			widgets/kpColorPalette.cpp (4 lines)
M			widgets/kpDefaultColorCollection.cpp (1 line)
M			widgets/kpDocumentSaveOptionsWidget.cpp (88 lines)
M			widgets/kpDualColorButton.cpp (36 lines)
M			widgets/kpPrintDialogPage.cpp (6 lines)
M			widgets/kpTransparentColorCell.cpp (6 lines)
M			widgets/toolbars/kpColorToolBar.cpp (13 lines)
M			widgets/toolbars/kpToolToolBar.cpp (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	51423	f561f6d		Feb 11 2019, 5:05 PM	★	★
Diff 2	51681	28bb159	- Fix compilation	Feb 14 2019, 2:21 PM	★	★
Diff 3	51684	28bb159	R374:fff60307ff06c657a67c81cfbfdb067cbd218880	Feb 14 2019, 2:38 PM	★	★