AsciiDoc: Add folding for sections
ClosedPublic

Authored by andreasgr on Sun, Feb 10, 2:23 PM.

Details

Summary

As D18516 is commited now, we can add sound folding for sections.

  • Add contexts to support section folding in highlighting definition asciidoc.xml.
  • Update and improve test file asciidoc.adoc.
  • Update created .fold, .html and .ref files.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
andreasgr created this revision.Sun, Feb 10, 2:23 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSun, Feb 10, 2:23 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
andreasgr requested review of this revision.Sun, Feb 10, 2:23 PM
dhaumann accepted this revision.Mon, Feb 11, 7:00 AM

I think this change is ok. Although, adding many RegExprs is slow compared to other rules.

This revision is now accepted and ready to land.Mon, Feb 11, 7:00 AM

... Although, adding many RegExprs is slow compared to other rules.

I understand that.
I just don't see how to achieve the needed matches using other rules.
E.g. a simple string rule using == is not sufficient to correctly match a level 1 section title.

This revision was automatically updated to reflect the committed changes.