andreasgr (Andreas Gratzer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Wed, Jan 23, 4:04 PM (3 w, 6 d)
Availability
Available

Recent Activity

Mon, Feb 11

andreasgr added a comment to T7860: Handling of removable drives and mounted shares.

I experience the same behavior with BTRFS subvolumes mounted by systemd mount units.
Though not on _every_ boot, after a seemingle random number of boots the device id changed and Baloo indexes the subvolume all over again.

Mon, Feb 11, 12:22 PM · Baloo
andreasgr added a comment to D18895: AsciiDoc: Add folding for sections.

... Although, adding many RegExprs is slow compared to other rules.

Mon, Feb 11, 11:00 AM · Frameworks, Kate

Sun, Feb 10

andreasgr requested review of D18895: AsciiDoc: Add folding for sections.
Sun, Feb 10, 2:23 PM · Frameworks, Kate

Thu, Jan 31

andreasgr added a comment to D18617: AsciiDoc: Fix highlighting of include directive.

Looks good to me. Please increase the "version" number whenever you change an highlighting file.

Thu, Jan 31, 5:43 AM · Frameworks, Framework: Syntax Highlighting, Kate

Wed, Jan 30

andreasgr requested review of D18617: AsciiDoc: Fix highlighting of include directive.
Wed, Jan 30, 2:34 PM · Frameworks, Framework: Syntax Highlighting, Kate

Tue, Jan 29

andreasgr added a comment to D18475: Add AsciiDoc support.
  1. I apply your patch: arc patch D18475
Tue, Jan 29, 8:34 AM · Frameworks, Kate, Framework: Syntax Highlighting

Mon, Jan 28

andreasgr added a comment to D18475: Add AsciiDoc support.

Hi!!
Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use make test and autotests/update-reference-data.sh.

Mon, Jan 28, 1:20 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr added a comment to D18475: Add AsciiDoc support.

If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal).

Mon, Jan 28, 12:12 PM · Frameworks, Kate, Framework: Syntax Highlighting

Sun, Jan 27

andreasgr updated the diff for D18475: Add AsciiDoc support.

Fix diff.

Sun, Jan 27, 7:28 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr updated the diff for D18475: Add AsciiDoc support.
  • Added test AsciiDoc.
Sun, Jan 27, 7:21 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr updated the diff for D18475: Add AsciiDoc support.
  • Drop unused 'admonition' keyword list.
  • Rename itemData elements to start with capital letters.
  • Enable escaping in block and section titles.
Sun, Jan 27, 7:11 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr added a comment to D18475: Add AsciiDoc support.

Running the katesyntaxhighlighting indexer tells me:

katehighlightingindexer::KeywordChecker::check: "syntax-highlighting/data/syntax/asciidoc.xml" Unused keyword lists: "admonition"

Could you fix this? Usually, keyword completion should be context dependent anyways (currently a bug), so soon your unused list will indeed not have any effect.

Sun, Jan 27, 5:28 PM · Frameworks, Kate, Framework: Syntax Highlighting
andreasgr updated the diff for D18475: Add AsciiDoc support.

Drop custom colors and backgrounds.

Sun, Jan 27, 2:59 PM · Frameworks, Kate, Framework: Syntax Highlighting

Sat, Jan 26

andreasgr added a comment to D18475: Add AsciiDoc support.

Hi!!
Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use make test and autotests/update-reference-data.sh.

I am not a reviewer, but I want to add some recommendations in relation to the itemData's:

  • On lines 467, 476 and 485 you use harded colors for the fonts. Ideally, don't use them, but use the default styles, since a better visualization is achieved in the different schemes: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
  • On lines 469 & 471 you use background color, and on lines 466-467, 473-474, 479-481 and 490 you use background color, but not font color. Try not to use background color if it's not necessary, to get a better visualization in the different schemes. However, if you need background color, it also specifies the font color, to avoid readability problems in some color schemes (for example, the background color &monospaced_bg; with dsNormal is not readable in dark schemes).
Sat, Jan 26, 6:17 AM · Frameworks, Kate, Framework: Syntax Highlighting

Fri, Jan 25

andreasgr updated the diff for D18475: Add AsciiDoc support.
  • Add missing allowed leading characters for links.
  • Add escaping of attribute usage.
  • Avoid highlighting of spaces inside table.
Fri, Jan 25, 3:11 PM · Frameworks, Kate, Framework: Syntax Highlighting

Wed, Jan 23

andreasgr requested review of D18475: Add AsciiDoc support.
Wed, Jan 23, 5:02 PM · Frameworks, Kate, Framework: Syntax Highlighting