Differential D18895

AsciiDoc: Add folding for sections
ClosedPublic
Actions

Authored by andreasgr on Feb 10 2019, 2:23 PM.

Details

Reviewers

dhaumann

Group Reviewers

Framework: Syntax Highlighting

Commits

R216:54ac6d34a339: AsciiDoc: Add folding for sections

Summary

As D18516 is commited now, we can add sound folding for sections.

Add contexts to support section folding in highlighting definition asciidoc.xml.
Update and improve test file asciidoc.adoc.
Update created .fold, .html and .ref files.

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

andreasgr created this revision.Feb 10 2019, 2:23 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 10 2019, 2:23 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

andreasgr requested review of this revision.Feb 10 2019, 2:23 PM

I think this change is ok. Although, adding many RegExprs is slow compared to other rules.

This revision is now accepted and ready to land.Feb 11 2019, 7:00 AM

In D18895#409743, @dhaumann wrote:

... Although, adding many RegExprs is slow compared to other rules.

I understand that.
I just don't see how to achieve the needed matches using other rules.
E.g. a simple string rule using == is not sufficient to correctly match a level 1 section title.

Closed by commit R216:54ac6d34a339: AsciiDoc: Add folding for sections (authored by dhaumann). · Explain WhyFeb 11 2019, 9:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/folding/asciidoc.adoc.fold (716 lines)
M			autotests/html/asciidoc.adoc.html (14 lines)
M			autotests/input/asciidoc.adoc (14 lines)
M			autotests/reference/asciidoc.adoc.ref (14 lines)
M			data/syntax/asciidoc.xml (103 lines)