Details
- Reviewers
mlaurent bruns - Group Reviewers
Baloo - Commits
- R293:f5f1ae889fe9: add baloo engine debugging category
Diff Detail
- Repository
- R293 Baloo
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8086 Build 8104: arc lint + arc unit
src/engine/CMakeLists.txt | ||
---|---|---|
31 | I've been asked to split this from D18664: Baloo engine: treat every non-success code as a failure |
Ok so you need to commit this one first and making second patch dependancy against it.
baloo.categories | ||
---|---|---|
4 | description "Baloo engine debug" -> "Baloo Engine" |
Baloo::ENGINE it's wrong as you generate it as "IDENTIFIER "ENGINE" CATEGORY_NAME "org.kde.baloo.engine")"
it's not Baloo::ENGINE but ENGINE
so you need to change IDENTIFIER "ENGINE" in ecm_qt_declare_logging_category(
i.e. add "DEFAULT_SEVERITY Warning" in ecm_qt_declare_logging_category
compare with https://phabricator.kde.org/source/baloo/browse/master/src/kioslaves/timeline/CMakeLists.txt
ecm_qt_declare_logging_category(kio_timeline_SRCS
HEADER kio_timeline_debug.h IDENTIFIER Baloo::KIO_TIMELINE DEFAULT_SEVERITY Warning CATEGORY_NAME kf5.kio.kio_timeline
yep you force DEFAULT_SEVERITY Warning
here ;ecm_qt_declare_logging_category(
BALOO_ENGINE_SRCS HEADER "enginedebug.h"
IDENTIFIER "ENGINE"
CATEGORY_NAME "org.kde.baloo.engine")
I don't see where you force DEFAULT_SEVERITY here :)
is it now how it's supposed to look in the end? not really sure where .category syntax is defined