Differential D18849

[KPropertiesDialog] Fix group combobox
ClosedPublic
Actions

Authored by cfeck on Feb 8 2019, 1:40 PM.

Details

Reviewers
broulik
Group Reviewers
Frameworks
Dolphin
Commits
R241:2bba2c0795d7: [KPropertiesDialog] Fix group combobox
Summary

groupList was never initialized with KUser::groupNames(), causing the subsequent combobox setup to be skipped.

BUG: 403074

Test Plan

kpropertiesdialogtest shows a combobox with users and audio groups on my system. Without this patch, no combobox appears.

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
cfeck created this revision.Feb 8 2019, 1:40 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 8 2019, 1:40 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cfeck requested review of this revision.Feb 8 2019, 1:40 PM
broulik accepted this revision.Feb 8 2019, 1:44 PM
This revision is now accepted and ready to land.Feb 8 2019, 1:44 PM
Closed by commit R241:2bba2c0795d7: [KPropertiesDialog] Fix group combobox (authored by cfeck). · Explain WhyFeb 18 2019, 10:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kpropertiesdialog.cpp (4 lines)

Diff 51180

View Options

src/widgets/kpropertiesdialog.cpp

Loading...