- add settings for explicitly setting the value of Language-Team
- it allows to specify the value of Language-Team setting for application and to override it for specific projects
Details
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/catalog/gettextheader.cpp | ||
---|---|---|
365 | you can remove the ifndef NOKDE we don't release a non-kde build anymore for lokalize. It's built with craft, for instance here https://binary-factory.kde.org/job/Lokalize_Nightly_win32/ |
Sorry I've been a bit slow on this review, I'll check the behavior by the end of the week
src/prefs/prefs.cpp | ||
---|---|---|
116 | Can you use the new signal API for this one ? |
It's a great idea, I would have a few suggestions :
- Scrap the automatic option
- if the application checkbox (kcfg_overrideLangTeam) is unchecked (by default), show the default value in the text field next to it instead (greyed out)
- Replace the combobox in the Project setting by a checkbox
- show the Application value (default or override) if it is unchecked (greyed out)
src/prefs/prefs_identity.ui | ||
---|---|---|
156 | You can add change the label to "Default Language-Team:" | |
src/project/prefs_projectmain.ui | ||
143 | Please add a Langage-Team: label before the combobox or we don't know what this relates to |
Thanks for your reply!
I'll do it when I have enough time (unfortunately, I'm too busy to get to it right now).
I missed the notifications on the changes, I'll review it over the week-end.
Of course you are welcome to help
Not very user-friendly in my opinion, I listed some issues here: https://bugs.kde.org/show_bug.cgi?id=410358