| jgrulich | |
| apol | |
| dfaure |
| Frameworks |
Currently KRun in Flatpak/Snap doesn't support portals so it can't launch an application
for a given url (because it can't break through sandbox). This patch allows KRun to use
portals to pass the url through sandbox. QDesktopServices::openUrl handles that case and sends
appropriate DBus calls to portals, so URIs will be proccessed accordingly by host system.
FEATURE: 399380
I couldn't build KIO from master in current flatpak KDE runtime (even without the patch), so here are commands to test the patch on top
of KIO 5.54.1:
to run it with just compiled KIO (the compiled libraries are located in bin directory inside your build directory)
Now link clicks should pass sandbox and do the appropriate actions (open browser for http links, email application for mailto links,
file manager for file://...)
| No Linters Available |
| No Unit Test Coverage |
| Buildable 8604 | |
| Build 8622: arc lint + arc unit |
Looks good from the portal point of view, but I would rather wait for someone who knows KRun internally to approve this review.
This should only be done if KRun::setEnableExternalBrowser(false) wasn't called, otherwise it will break KParts' BrowserRun subclass and Konqueror's KonqRun (who use KRun to actually find out the mimetype of the file, not to launch another browser).
T
his means adding a bool d->m_externalBrowserEnabled in KRun, since right now we can't know that it was called if the settings don't actually define an external browser.
Ping?
Btw, I couldn't find any usages of setEnableExternalBrowser in BrowserRun or KonqRun but there is an usage after instantiating an object of KonqRun (in KonqMainWindow::openUrl). It's strange that a caller must call the function itself or it will crash...
Overall, it looks good to me. Let's get this in.
Regarding your process, I think you could have passed --devel on the step 7 and compiled kio there together with konversation. Maybe that makes it a bit easier next time.
| src/widgets/krun.cpp | ||
|---|---|---|
| 956 ↗ | (On Diff #51047) | Maybe you can swap the condition so the function is only called when m_externalBrowserEnabled is true. |
@apol I didn't applied for KDE Developer Account yet (I'm new here) so I can't, sorry.