[kcmkwin] Rename EffectModel to EffectsModel
AcceptedPublic

Authored by zzag on Sun, Feb 3, 8:11 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Summary

Model names have plural form.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7886
Build 7904: arc lint + arc unit
zzag created this revision.Sun, Feb 3, 8:11 PM
Restricted Application added a project: KWin. · View Herald TranscriptSun, Feb 3, 8:11 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sun, Feb 3, 8:11 PM
zzag updated this revision to Diff 50803.Sun, Feb 3, 8:17 PM

sneaky udpate

zzag updated this revision to Diff 50827.Mon, Feb 4, 10:23 AM

Rebase.

zzag updated this revision to Diff 50891.Mon, Feb 4, 9:16 PM

Rebase.

davidedmundson accepted this revision.Wed, Feb 20, 1:03 PM
davidedmundson added a subscriber: davidedmundson.

Model names have plural form.

Not universally, even the base class is in the singular. I certainly wouldn't bother changing any other instances you find around the rest of Plasma.

I don't think anyone could mistakenly think this is a model of just one effect, so it's one of those changes that doesn't really make a difference.

This revision is now accepted and ready to land.Wed, Feb 20, 1:03 PM