Differential D18712

[kcmkwin] Rename EffectModel to EffectsModel
ClosedPublic
Actions

Authored by zzag on Feb 3 2019, 8:11 PM.

Tags

Subscribers

davidedmundson, kwin

Details

Reviewers

Group Reviewers

Commits

R108:b91cfae3080b: [kcmkwin] Rename EffectModel to EffectsModel

Summary

Model names have plural form.

Test Plan

Compiles.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.Feb 3 2019, 8:11 PM

Restricted Application added a project: KWin. · View Herald TranscriptFeb 3 2019, 8:11 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Feb 3 2019, 8:11 PM

Harbormaster completed remote builds in B7830: Diff 50801.Feb 3 2019, 8:12 PM

sneaky udpate

Harbormaster completed remote builds in B7832: Diff 50803.Feb 3 2019, 8:17 PM

zzag added a dependency: D18707: [kcmkwin] Remove some name duplication in EffectModel.Feb 3 2019, 8:21 PM

zzag added a dependent revision: D18713: [kcmkwin] Rename EffectsModel::m_effectsList to EffectsModel::m_effects.Feb 3 2019, 8:29 PM

Rebase.

Harbormaster completed remote builds in B7847: Diff 50827.Feb 4 2019, 10:23 AM

Rebase.

Harbormaster completed remote builds in B7886: Diff 50891.Feb 4 2019, 9:16 PM

Model names have plural form.

Not universally, even the base class is in the singular. I certainly wouldn't bother changing any other instances you find around the rest of Plasma.

I don't think anyone could mistakenly think this is a model of just one effect, so it's one of those changes that doesn't really make a difference.

This revision is now accepted and ready to land.Feb 20 2019, 1:03 PM

Closed by commit R108:b91cfae3080b: [kcmkwin] Rename EffectModel to EffectsModel (authored by zzag). · Explain WhyMar 18 2019, 11:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcmkwin/common/CMakeLists.txt (2 lines)
V			kcmkwin/common/{effectmodel.h → effectsmodel.h}
V			kcmkwin/common/{effectmodel.cpp → effectsmodel.cpp}
V			kcmkwin/common/{effectsmodel.h ← effectmodel.h} (6 lines)
V			kcmkwin/common/{effectsmodel.cpp ← effectmodel.cpp} (44 lines)
M			kcmkwin/kwindesktop/animationsmodel.h (4 lines)
M			kcmkwin/kwindesktop/animationsmodel.cpp (14 lines)
M			kcmkwin/kwineffects/effectsfilterproxymodel.cpp (12 lines)
M			kcmkwin/kwineffects/kcm.h (4 lines)
M			kcmkwin/kwineffects/kcm.cpp (8 lines)

Diff 54201

kcmkwin/common/CMakeLists.txt

Loading...

kcmkwin/common/effectmodel.h

Loading...

kcmkwin/common/effectmodel.cpp

Loading...

kcmkwin/common/effectsmodel.h

Loading...

kcmkwin/common/effectsmodel.cpp

Loading...

kcmkwin/kwindesktop/animationsmodel.h

Loading...

kcmkwin/kwindesktop/animationsmodel.cpp

Loading...

kcmkwin/kwineffects/effectsfilterproxymodel.cpp

Loading...

kcmkwin/kwineffects/kcm.h

Loading...

kcmkwin/kwineffects/kcm.cpp

Loading...