Remove monochrome font preferences icon
ClosedPublic

Authored by GB_2 on Feb 3 2019, 5:02 PM.

Details

Summary

Removes the monochrome font preferences icon to prevent showing it instead of the colorful icon in the system settings "Fonts" category tooltip.

Test Plan

Open the system settings and hover over the "Fonts" category.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Feb 3 2019, 5:02 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 3 2019, 5:02 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 3 2019, 5:02 PM
ndavis added a subscriber: ndavis.Feb 3 2019, 6:35 PM

Is this icon used by any other KDE software or 3rd party applications?

Is this icon used by any other KDE software or 3rd party applications?

Yes, quite a few: https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-font

Those apps won't experience any breakage, but they will suddenly display the scaled-down color version.

GB_2 added a comment.EditedFeb 4 2019, 6:33 AM

Is this icon used by any other KDE software or 3rd party applications?

Yes, quite a few: https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-font

Those apps won't experience any breakage, but they will suddenly display the scaled-down color version.

In most places it is used correctly as a SySe category icon and I think it would be fine if it would turn into a colorful one.
It needs to be changed here though (the "All Fonts" list item):


We could use gnumeric-font as an alternative.

Can you improve the font selection icon in a separate patch please?

GB_2 added a comment.Feb 7 2019, 5:44 PM

Can you improve the font selection icon in a separate patch please?

Is it bad that the branch name is wrong then though?

Nah, that has no effect on anything.

GB_2 updated this revision to Diff 51167.Feb 8 2019, 11:33 AM

Revert font selection icon change

GB_2 edited the summary of this revision. (Show Details)Feb 8 2019, 11:34 AM
GB_2 edited the test plan for this revision. (Show Details)
GB_2 retitled this revision from Remove monochrome font preferences icon and improve font selection icon to Remove monochrome font preferences icon.
ngraham accepted this revision.Feb 8 2019, 4:49 PM
This revision is now accepted and ready to land.Feb 8 2019, 4:49 PM
This revision was automatically updated to reflect the committed changes.