Changes the icon for the "None" item in grid view KCMs (present in the Splash Screen KCM) to differentiate it from other items that have no preview.
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Commits
- R296:e22529eeed0c: Use different "None" item icon in grid view KCMs
Open the Splash Screen KCM.
Diff Detail
- Repository
- R296 KDeclarative
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed.
Yeah, it's the only X icon, I think we need to make a copy of it that is not red in breeze-icons (we could call it edit-none or something).
I agree with you here. It may seem that you are selecting something different. What about a stop sign and behind it a representation of the splash screen. So as to signal that you are not wanting a splash screen. The concept is great though! Many people care little for the splash screen and prefer to see the booting output.
Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled.
Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled.
I see, maybe the label could be more descriptive then? Use something like "Black", or "No splash"?
I think "None" is fine, because you already know that you are selecting the splash screen and if it was specific to the splash this would be a bit more complicated to change and this wouldn't be for all KCMs that can have a "None" item then.
Yeah, the item already has a "None" label; we're just trying to figure out what the icon should be. I think an X is okay choice for suggesting "there's nothing here".