Use different "None" item icon in grid view KCMs
ClosedPublic

Authored by GB_2 on Feb 2 2019, 4:20 PM.

Details

Summary

Changes the icon for the "None" item in grid view KCMs (present in the Splash Screen KCM) to differentiate it from other items that have no preview.

Test Plan

Open the Splash Screen KCM.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Feb 2 2019, 4:20 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 2 2019, 4:20 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 2 2019, 4:20 PM
ngraham added a subscriber: ngraham.Feb 2 2019, 8:17 PM

Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed.

GB_2 added a comment.Feb 2 2019, 8:20 PM

Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed.

Yeah, it's the only X icon, I think we need to make a copy of it that is not red in breeze-icons (we could call it edit-none or something).

abetts added a subscriber: abetts.Feb 2 2019, 8:21 PM

Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed.

I agree with you here. It may seem that you are selecting something different. What about a stop sign and behind it a representation of the splash screen. So as to signal that you are not wanting a splash screen. The concept is great though! Many people care little for the splash screen and prefer to see the booting output.

GB_2 added a comment.EditedFeb 2 2019, 8:23 PM

Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed.

I agree with you here. It may seem that you are selecting something different. What about a stop sign and behind it a representation of the splash screen. So as to signal that you are not wanting a splash screen. The concept is great though! Many people care little for the splash screen and prefer to see the booting output.

Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled.

abetts added a comment.Feb 2 2019, 8:27 PM

Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled.

I see, maybe the label could be more descriptive then? Use something like "Black", or "No splash"?

GB_2 added a comment.Feb 2 2019, 8:31 PM

Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled.

I see, maybe the label could be more descriptive then? Use something like "Black", or "No splash"?

I think "None" is fine, because you already know that you are selecting the splash screen and if it was specific to the splash this would be a bit more complicated to change and this wouldn't be for all KCMs that can have a "None" item then.

Yeah, the item already has a "None" label; we're just trying to figure out what the icon should be. I think an X is okay choice for suggesting "there's nothing here".

GB_2 added a comment.Feb 2 2019, 8:36 PM
In D18675#404096, @GB_2 wrote:

Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed.

Yeah, it's the only X icon, I think we need to make a copy of it that is not red in breeze-icons (we could call it edit-none or something).

Let's do this then.

GB_2 updated this revision to Diff 50774.Feb 3 2019, 3:32 PM

Use new edit-none icon

GB_2 edited the summary of this revision. (Show Details)Feb 3 2019, 3:32 PM
ngraham accepted this revision.Feb 3 2019, 3:33 PM

Master only please.

This revision is now accepted and ready to land.Feb 3 2019, 3:33 PM
This revision was automatically updated to reflect the committed changes.