Add missing QStandardPaths to fix build
ClosedPublic

Authored by asturmlechner on Feb 2 2019, 4:17 PM.

Diff Detail

Repository
R181 Amarok
Branch
buildfix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7784
Build 7802: arc lint + arc unit
asturmlechner created this revision.Feb 2 2019, 4:17 PM
Restricted Application added a subscriber: amarok-devel. · View Herald TranscriptFeb 2 2019, 4:17 PM
asturmlechner requested review of this revision.Feb 2 2019, 4:17 PM
yurchor added a subscriber: yurchor.Feb 2 2019, 8:24 PM

Is it really needed?

It seems that build factory can build Amarok even without this include.

https://build.kde.org/job/Extragear/job/amarok/

Thanks in advance for your answer.

-c /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:101:162: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]
                           ki18n( "IRC:\nirc.freenode.net - #amarok, #amarok.de, #amarok.es, #amarok.fr\n\nFeedback:\namarok@kde.org\n\n(Build Date: %1)" ).subs( __DATE__ ).toString(),
                                                                                                                                                                  ^~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp: In function ‘int main(int, char**)’:
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:40: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                        ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:73: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                                                         ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:361:82: note: #pragma message: PORT KF5: This *if* should be moved to activateRequested() slot
 #pragma message("PORT KF5: This *if* should be moved to activateRequested() slot")
                                                                                  ^
yurchor accepted this revision.Feb 2 2019, 8:48 PM
This revision is now accepted and ready to land.Feb 2 2019, 8:48 PM
heikobecker accepted this revision.Feb 2 2019, 8:49 PM
heikobecker added a subscriber: heikobecker.

Yeah, that didn't happen for me as well, but QSP is actually used (line 75).

This occurred after switching to ninja by default, maybe related. But I hadn't built amarok before that in a while.

asturmlechner closed this revision.Feb 2 2019, 8:55 PM