Ring-field focusing feature.
ClosedPublic

Authored by TallFurryMan on Jan 25 2019, 8:46 AM.

Details

Summary

Adds inner and outer limits to filter stars when running a full-frame focus procedure.
When option "Full Field" is enabled in the Focus tab, the procedure will first detect
stars that are visible on the frame, using either the SEP method (if selected) or the
Centroid method, and remove stars not in the ring surface bounded by the inner and
outer radius values before calculating the mean HFR.

Test Plan

Basic items:

  • Default options are "Sub Frame", and inner/outer radius boxes disabled.
  • Selecting "Full Frame" enables the radius boxes, default values are 0% and 100%, respectively.
  • Tooltips are coherent, and match their gadgets.
  • Enabling "Sub Frame" disables "Full Frame", and enabling "Full Frame" disables "Sub Frame".
  • Procedure values and selection are remembered from one execution of KStars to the other.

Procedure:

  • Filter use is enabled with option "Full Frame".
  • Filter is inoperant if inner/outer radius value are 0% and 100%, respectively.
  • If one of the radius values is not the default, the filter is used.
  • When the filter is used, two blue dashed circles are displayed on the focus frame (values 0% and 100% are not visible).
  • Stars inside the inner circle are disregarded for the focus procedure, and are not marked by the star overlay.
  • Stars outside the outer circle are disregarded for the focus procedure, and are not marked by the star overlay.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.Jan 25 2019, 8:46 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 25 2019, 8:46 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Jan 25 2019, 8:46 AM
mutlaqja requested changes to this revision.Feb 2 2019, 10:50 AM

Great, I just tested it now and appears to work fairly well. The only issue I noticed now is that the exclusion pattern remains as overlay even when I uncheck "Full Field". It should be disabled by then.

This revision now requires changes to proceed.Feb 2 2019, 10:50 AM

Great, I just tested it now and appears to work fairly well. The only issue I noticed now is that the exclusion pattern remains as overlay even when I uncheck "Full Field". It should be disabled by then.

You mean at the moment you uncheck the "full field" box, or when you execute a capture after unchecking? I'll double-check anyway.

Actually, I'm working on it now and it's almost done, so don't worry about it.

mutlaqja accepted this revision.Feb 2 2019, 11:10 AM
This revision is now accepted and ready to land.Feb 2 2019, 11:10 AM
This revision was automatically updated to reflect the committed changes.