Port to new connect syntax
ClosedPublic
Actions

Authored by chinmoyr on Jan 22 2019, 1:42 PM.

Details

Reviewers

davidedmundson
apol

Commits

R241:53bba36a78c4: Port to new connect syntax

Summary

Port some Q_PRIVATE_SLOTS in CopyJob and TransferJob to new syntax.

Test Plan

Relevant unit test pass.

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

chinmoyr requested review of this revision.Jan 22 2019, 1:42 PM

I hope that all tests pass, not just the relevant. ;)

This revision is now accepted and ready to land.Jan 27 2019, 4:31 AM

What happened here?

Restore sourceStated in CopyJob.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/core/copyjob.h (4 lines)
M			src/core/copyjob.cpp (23 lines)
M			src/core/job_p.h (3 lines)
M			src/core/transferjob.h (5 lines)
M			src/core/transferjob.cpp (41 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50058	8c3f000		Jan 22 2019, 1:42 PM	★	★
Diff 2	53013	8c3f000	Restore sourceStated in CopyJob.	Mar 2 2019, 5:13 PM	★	★
Diff 3	53014	403aeda	R241:53bba36a78c4ab16c3c439a5c79ab4004699f269	Mar 2 2019, 5:24 PM	★	★