BUG: 109241
FIXED-IN: 5.55
Add some proper edit-delete-shred icons; use correct 2px margins for the 32px edit-delete icon.
Details
Details
- Reviewers
ndavis ngraham - Group Reviewers
VDG - Commits
- R266:a8d82b00afdb: Add proper edit-delete-shred icons
The 32px edit-delete icon:
Diff Detail
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Symlink shenanigans make the patch not apply due to that Phab bug. :(
Created and checked out branch arcpatch-D18439. Checking patch icons/actions/32/edit-delete.svg... Checking patch icons/actions/32/edit-delete-shred.svg... Checking patch dev/null => icons/actions/24/edit-delete-shred.svg... error: dev/null: does not exist in index Checking patch dev/null => icons/actions/22/edit-delete-shred.svg... error: dev/null: does not exist in index Checking patch dev/null => icons/actions/16/edit-delete-shred.svg... error: dev/null: does not exist in index Checking patch icons-dark/actions/32/edit-delete.svg... Checking patch icons-dark/actions/32/edit-delete-shred.svg... Checking patch dev/null => icons-dark/actions/24/edit-delete-shred.svg... error: dev/null: does not exist in index Checking patch dev/null => icons-dark/actions/22/edit-delete-shred.svg... error: dev/null: does not exist in index Checking patch dev/null => icons-dark/actions/16/edit-delete-shred.svg... error: dev/null: does not exist in index Applied patch icons/actions/32/edit-delete.svg cleanly. Applied patch icons/actions/32/edit-delete-shred.svg cleanly. Applied patch icons-dark/actions/32/edit-delete.svg cleanly. Applied patch icons-dark/actions/32/edit-delete-shred.svg cleanly.
If you give me a list of symlink changes that need to be done, I can make them manually and then you can rebase this patch to only change icons.
Comment Actions
Also, visually speaking, I think that the checkerboard grid on the bottom is too fine. Making it a bit more coarse might improve things. Also have you experimented with using vertical lines instead of a checkerboard? Or maybe a checkerboard of vertical lines rather than squares? That's what my shredder does.
Comment Actions
Better, though for the 32px version, the shreds feel too skinny. Maybe making them 2px wide might improve the look?
Comment Actions
This has smaller gaps, which are still large enough imo.
This has bigger gaps and isn't quite as pretty.
Do you think these are better?
This has smaller gaps, which are still large enough imo.
This has bigger gaps and isn't quite as pretty.
Comment Actions
Still can't actually apply the patch to land it using Phab. Can you remove the symlink-related changes from this patch and then provide a list of them so I can do them manually?