Differential D18436

[platform/virtual] Swap buffers in EGL GBM backend
ClosedPublic
Actions

Authored by romangg on Jan 21 2019, 7:21 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:1e6f6700f8a3: [platform/virtual] Swap buffers in EGL GBM backend
Summary

The virtual platform did not actually present content and spin the
compositor. Let's do this from now on , first for the EGL GBM backend.

Test Plan

All tests pass according to Vlad

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Jan 21 2019, 7:21 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 21 2019, 7:21 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Jan 21 2019, 7:21 PM
zzag added a subscriber: zzag.EditedJan 21 2019, 8:44 PM

98% tests passed

If a change breaks some tests, then that change can't be merged. Make sure you have all dependencies installed https://github.com/KDE/kwin/blob/master/TESTING.md.

romangg added a comment.Jan 22 2019, 10:52 AM
In D18436#397692, @zzag wrote:

98% tests passed

If a change breaks some tests, then that change can't be merged. Make sure you have all dependencies installed https://github.com/KDE/kwin/blob/master/TESTING.md.

The failing tests seem unrelated. I installed missing dependencies as in the link and tried to run ctest with xvfb-run. Now even more unrelated tests fail. You have an idea what the reason could be?

graesslin added a subscriber: graesslin.Jan 22 2019, 5:28 PM

Do the tests pass without the change?

romangg added a comment.Jan 22 2019, 5:44 PM
In D18436#398105, @graesslin wrote:

Do the tests pass without the change?

They didn't. After a reboot I ran the test suite again on one of the child revisions (that have the changes here incorporated) and all but kwin-testDbusInterface passed. Just wishing for Gitlab and a working CI suite...

zzag accepted this revision.Jan 22 2019, 9:32 PM

All tests pass.

Though it would be worth to investigate why tests are failing in your case.

(please remove "98% tests passed, 3 tests failed out of 139 ..." from the test plan)

This revision is now accepted and ready to land.Jan 22 2019, 9:32 PM
romangg edited the test plan for this revision. (Show Details)Jan 22 2019, 9:37 PM
Closed by commit R108:1e6f6700f8a3: [platform/virtual] Swap buffers in EGL GBM backend (authored by romangg). · Explain WhyFeb 21 2019, 10:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52250

View Options

plugins/platforms/virtual/egl_gbm_backend.cpp

Loading...