| zzag |
| KWin |
Adds an autotest to show that KWin fails an assertion when a client tries to
resize a sub-surface.
Since it is the first autotest dealing with sub-surfaces explicitly additional
autotest helpers are introduced to allow that.
We also add a new signal in Compositor to spy on to know when the buffer swap
has been completed.
Test fails as expected:
QFATAL : KWin::BufferSizeChangeTest::testShmBufferSizeChangeOnSubSurface() ASSERT: "image.size() == m_size" in file /home/roman/dev/kde/src/kde/workspace/kwin/platformsupport/scenes/opengl/abstract_egl_backend.cpp, line 394 FAIL! : KWin::BufferSizeChangeTest::testShmBufferSizeChangeOnSubSurface() Received a fatal error. Loc: [Unknown file(0)] Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted, 367ms ********* Finished testing of KWin::BufferSizeChangeTest *********
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Yes, probably you know already since you accepted D18453, but for completeness: it's that one. ;)
| autotests/integration/buffer_size_change_test.cpp | ||
|---|---|---|
| 6 | Nitpick: missing "(C)". :D | |
| 22–24 | Includes should be sorted. | |
| 52 | Missing "this test verifies ..." | |
| 56 | Just QVERIFY(surface); | |
| 58 | Why ShellSurface? | |
| 60 | Could you please add an explanatory comment for this flush? | |
| 80 | Also, it would be great to destroy the client, though that's not mandatory. :-) | |
| autotests/integration/buffer_size_change_test.cpp | ||
|---|---|---|
| 56 | Please ignore this one. | |
| autotests/integration/buffer_size_change_test.cpp | ||
|---|---|---|
| 63 | We usually do QVERIFY after renderAndWaitForShown. :-) | |
| autotests/integration/buffer_size_change_test.cpp | ||
|---|---|---|
| 60 | Also, do we need it anyway (flush)? | |
Requesting changes to remove this revision from review queue.
Please don't use wl-shell in new autotests, or if you do, then please test xdg-shell as well.