Differential D18433

Add a Plasma Theme Preferences Icon
ClosedPublic
Actions

Authored by trickyricky26 on Jan 21 2019, 5:35 PM.

Details

Reviewers
ndavis
GB_2
ngraham
Group Reviewers
VDG
Commits
R266:04e756751ceb: Add a Plasma Theme Preferences Icon
Summary

Add a preferences-desktop-plasma-theme icon based on preferences-desktop-plasma with the color-split panel.

Test Plan

At 100%:

Diff Detail

Repository
R266 Breeze Icons
Branch
add-plasma-theme-icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7381
Build 7399: arc lint + arc unit
trickyricky26 created this revision.Jan 21 2019, 5:35 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 21 2019, 5:35 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Jan 21 2019, 5:35 PM
trickyricky26 planned changes to this revision.Jan 21 2019, 5:36 PM
trickyricky26 edited the summary of this revision. (Show Details)
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 added a reviewer: VDG.

I will make the Plasma logo the same size as the one in preferences-desktop-plasma.

trickyricky26 updated this revision to Diff 50006.Jan 21 2019, 5:46 PM
  • Make the Plasma Logo the same size as the Plasma Preferences Icon
trickyricky26 edited the test plan for this revision. (Show Details)Jan 21 2019, 5:46 PM
trickyricky26 edited the test plan for this revision. (Show Details)
ndavis accepted this revision.Jan 21 2019, 5:50 PM
ndavis added a subscriber: ndavis.

Looks good to me!

This revision is now accepted and ready to land.Jan 21 2019, 5:50 PM
GB_2 accepted this revision.Jan 21 2019, 5:55 PM
GB_2 added a subscriber: GB_2.

+1

ngraham accepted this revision.Jan 21 2019, 6:03 PM
ngraham added a comment.Jan 21 2019, 6:06 PM

We have preferences-desktop-theme-global; shouldn't this be preferences-desktop-theme-plasma?

ndavis added a comment.Jan 21 2019, 6:12 PM
In D18433#397602, @ngraham wrote:

We have preferences-desktop-theme-global; shouldn't this be preferences-desktop-theme-plasma?

Good point

ngraham requested changes to this revision.Jan 21 2019, 6:14 PM

Please change the name to preferences-desktop-theme-plasma, and then I'll land it!

This revision now requires changes to proceed.Jan 21 2019, 6:14 PM
GB_2 added a comment.EditedJan 21 2019, 7:11 PM

It should fall back to preferences-desktop-plasma, because it fits better than preferences-desktop-theme and it is also what we use now.

ngraham added a comment.Jan 21 2019, 8:06 PM

After some discussion, we decided to keep this name to ensure a proper fallback path for themes without this icon.

ngraham accepted this revision.Jan 21 2019, 8:06 PM
This revision is now accepted and ready to land.Jan 21 2019, 8:06 PM
Closed by commit R266:04e756751ceb: Add a Plasma Theme Preferences Icon (authored by trickyricky26, committed by ngraham). · Explain WhyJan 21 2019, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50006

View Options

icons-dark/preferences/32/preferences-desktop-plasma-theme.svg

Loading...
View Options

icons/preferences/32/preferences-desktop-plasma-theme.svg

Loading...