Details

Reviewers

ngraham
cfeck

Group Reviewers

Gwenview
KDE Applications

Commits

R260:0118c47f3911: Create shortcut to focus navigator bar

Summary

BUG: 395184

Diff Detail

Repository

R260 Gwenview

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

shubham created this revision.Jan 20 2019, 7:36 AM

Restricted Application added a project: Gwenview. · View Herald TranscriptJan 20 2019, 7:36 AM

shubham requested review of this revision.Jan 20 2019, 7:36 AM

Harbormaster completed remote builds in B7338: Diff 49917.Jan 20 2019, 7:36 AM

shubham planned changes to this revision.Jan 20 2019, 7:38 AM

shubham added inline comments.

app/mainwindow.cpp
394	This connect produces error, don't know what's wrong here.
1733	How do I get a urlnavigator?

shubham added a subscriber: Gwenview.Jan 20 2019, 7:38 AM

ngraham added reviewers: Gwenview, KDE Applications, cfeck.Jan 20 2019, 5:44 PM

ngraham added inline comments.

app/mainwindow.cpp
391	This variable should and with "action", so it should be `replaceLocationAction`.

shubham requested review of this revision.Jan 30 2019, 2:14 PM

Ping?

ngraham added inline comments.Feb 1 2019, 9:01 PM

app/mainwindow.cpp
1733	This creates a new `KUrNavigator`. Just get the existing one through `mUrlNavigator`.

@ngraham thanks for reply, btw can you also reply to my inline comment at 394, I think thats perfectly valid connect syntax, still error is seen.

Use mUrlNavigator

Harbormaster completed remote builds in B7768: Diff 50695.Feb 2 2019, 7:02 AM

shubham retitled this revision from Shortcut to focus navigator bar to Create shortcut to focus navigator bar.Feb 2 2019, 7:03 AM

shubham marked 2 inline comments as done.

Fix connect error

Harbormaster completed remote builds in B7770: Diff 50697.Feb 2 2019, 7:28 AM

This version now works as expected, but now CTRL + L shortcut for replaceLocation action is an ambiguous shortcut with rotate left action. Please give me some suggestions, whether to change this shortcut or rotate left shortcut.

Nice can confirm that it works now. Perhaps we should change the "rotate left" shortcut to ctrl+⇧+r?

Change rotate left action's default shortcut to CTRL + SHIFT + L

Harbormaster completed remote builds in B7863: Diff 50851.Feb 4 2019, 3:12 PM

No, I meant change the "rotate left" shortcut to ctrl+⇧+r.

Use CTRL + SHIFT + R

ngraham accepted this revision.Feb 4 2019, 3:50 PM

This revision is now accepted and ready to land.Feb 4 2019, 3:50 PM

Closed by commit R260:0118c47f3911: Create shortcut to focus navigator bar (authored by shubham). · Explain WhyFeb 4 2019, 3:52 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			app/imageopscontextmanageritem.cpp (2 lines)
M			app/mainwindow.h (2 lines)
M			app/mainwindow.cpp (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49917	affe11d		Jan 20 2019, 7:36 AM	★	★
Diff 2	50695	affe11d	Use mUrlNavigator	Feb 2 2019, 7:02 AM	★	★
Diff 3	50697	affe11d	Fix connect error	Feb 2 2019, 7:28 AM	★	★
Diff 4	50851	affe11d	Change rotate left action's default shortcut to CTRL + SHIFT + L	Feb 4 2019, 3:12 PM	★	★
Diff 5	50853			Feb 4 2019, 3:25 PM	★	★
Diff 6	50856	f250b41	R260:0118c47f391103ac5894b204741e9b1810365398	Feb 4 2019, 3:52 PM	★	★

Create shortcut to focus navigator bar
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 50856

app/imageopscontextmanageritem.cpp

app/mainwindow.h

app/mainwindow.cpp

Create shortcut to focus navigator barClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 50856

app/imageopscontextmanageritem.cpp

app/mainwindow.h

app/mainwindow.cpp

Create shortcut to focus navigator bar
ClosedPublic
Actions

Revision Contents
Changeset List