[mobile/broadband] Port to SimpleKCM and FormLayout
AbandonedPublic

Authored by nicolasfella on Jan 19 2019, 6:12 PM.

Details

Reviewers
bshah
jgrulich
jbbgameich
Group Reviewers
Plasma: Mobile
Summary

This simplifies the code and ensures consistency with other FormLayout based KCMs

Before:

After:

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
broadband
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7323
Build 7341: arc lint + arc unit
nicolasfella created this revision.Jan 19 2019, 6:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2019, 6:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jan 19 2019, 6:12 PM
nicolasfella edited the summary of this revision. (Show Details)Jan 19 2019, 6:16 PM
nicolasfella edited the summary of this revision. (Show Details)

Needs a bit more padding. I'd put some whitespace between the checkboxes and the text field, and between the text field and the buttons. Also the bottoms kind of feel funny integrated into the form layout. I might put them on a row at the bottom of the page instead.

jbbgameich accepted this revision.Mar 20 2020, 11:24 PM
This revision is now accepted and ready to land.Mar 20 2020, 11:24 PM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald TranscriptMar 20 2020, 11:24 PM
This revision now requires review to proceed.Mar 20 2020, 11:24 PM
jgrulich requested changes to this revision.Mar 21 2020, 12:25 PM

I would approve, but @ngraham requested some changes.

This revision now requires changes to proceed.Mar 21 2020, 12:25 PM
bshah requested changes to this revision.Mar 23 2020, 8:10 AM

Currently I am working on making this actually functional, so let's drop this diff, my patch already uses the ScrollViewKCM.

nicolasfella abandoned this revision.Apr 14 2020, 9:17 PM