Differential D18345

Fix python binding generation for classes with deleted copy constructors
ClosedPublic
Actions

Authored by aacid on Jan 17 2019, 11:48 PM.

Details

Reviewers
lbeltrame
Commits
R240:a2a404f9f924: Fix python binding generation for classes with deleted copy constructors
Test Plan

kcoreaddons compiles again

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Jan 17 2019, 11:48 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJan 17 2019, 11:48 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Jan 17 2019, 11:48 PM
lbeltrame accepted this revision.Jan 18 2019, 10:58 AM

As far as I understand the logic of the whole thing, it looks sane. At some point we ought to find a way to properly test that the generated code...

This revision is now accepted and ready to land.Jan 18 2019, 10:58 AM
Closed by commit R240:a2a404f9f924: Fix python binding generation for classes with deleted copy constructors (authored by aacid). · Explain WhyJan 18 2019, 6:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mfind-modules/sip_generator.py (13 lines)

Diff 49830

View Options

find-modules/sip_generator.py

Loading...