Make the clock svg's shadows more logically correct and visually appropriate
ClosedPublic

Authored by ngraham on Jan 16 2019, 4:56 AM.

Details

Summary

This patch gives the clock's hour hand a shadow for the spindle too, since the shadow model we're using should logically have the spindle casting a shadow.

It also also increases the height of the minute hand shadow since its current length is short enough that it sometimes doesn't connect to anything.

CCBUG: 396612

Test Plan

Before:

After:

There are no visual changes whatsoever because the hour hand shadow is not currently displayed (See D17751 for background)

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 16 2019, 4:56 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 16 2019, 4:56 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 16 2019, 4:56 AM
ngraham edited the test plan for this revision. (Show Details)Jan 16 2019, 4:58 AM
ngraham edited the summary of this revision. (Show Details)
ngraham retitled this revision from Give the clock svg's hour hand a shadow for the spindle to Make the clock svg's shadows more logically correct and visually appropriate.Jan 16 2019, 5:02 AM
ngraham edited the summary of this revision. (Show Details)
ngraham added a reviewer: Plasma.
davidedmundson accepted this revision.Jan 16 2019, 12:33 PM
This revision is now accepted and ready to land.Jan 16 2019, 12:33 PM
This revision was automatically updated to reflect the committed changes.