Bring back KActivities support
ClosedPublic
Actions

Authored by elvisangelaccio on Jan 15 2019, 6:02 PM.

Details

Reviewers

Group Reviewers

Dolphin
Plasma

Commits

R318:5b463d82fed9: Bring back KActivities support

Summary

This code has been unused since the KF5 port.

Diff Detail

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio created this revision.Jan 15 2019, 6:02 PM

Restricted Application added a project: Dolphin. · View Herald TranscriptJan 15 2019, 6:02 PM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

elvisangelaccio requested review of this revision.Jan 15 2019, 6:02 PM

Harbormaster completed remote builds in B7134: Diff 49549.Jan 15 2019, 6:02 PM

Note: I have no clue what KActivities::ResourceInstance actually does, but it doesn't seem to break anything either.

ngraham added a reviewer: ivan.Jan 15 2019, 6:54 PM

I have no clue what KActivities::ResourceInstance actually does, but it doesn't seem to break anything either.

It tells the system about what item (folder in this case) you're currently looking at.
This allows KActivitiesStats tracking about what folders are frequently viewed as well as enables the Quick Share plasmoid to function.
Arguably, for a file manager this isn't very useful, but it's in principle the same thing Gwenview and others do.

Added set_package_properties to explain the optional feature

Harbormaster completed remote builds in B7300: Diff 49868.Jan 19 2019, 11:12 AM

Ping

Rebased

Harbormaster completed remote builds in B7641: Diff 50452.Jan 28 2019, 9:46 PM

I'll push in a week unless there are objections.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2019, 8:32 PM

Closed by commit R318:5b463d82fed9: Bring back KActivities support (authored by elvisangelaccio). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (9 lines)
M		src/CMakeLists.txt (4 lines)
D	M	src/config-dolphin.h.cmake (4 lines)
A	M	src/config-kactivities.h.cmake (1 line)
M		src/dolphinviewcontainer.h (6 lines)
M		src/dolphinviewcontainer.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49549	d23b842		Jan 15 2019, 6:02 PM	★	★
Diff 2	49868	784734c	- Added set_package_properties to explain the optional feature	Jan 19 2019, 11:12 AM	★	★
Diff 3	50452	8bc93b5	- Rebased	Jan 28 2019, 9:46 PM	★	★
Diff 4	54263	58084cf	R318:5b463d82fed9a443b098888c0aee8a7b3b322666	Mar 18 2019, 8:18 PM	★	★