Differential D18187

[KNewFileMenu] Don't emit fileCreated when creating a directory
ClosedPublic
Actions

Authored by chinmoyr on Jan 11 2019, 4:15 PM.

Details

Reviewers
ngraham
hein
Commits
R241:28dacfe07375: [KNewFileMenu] Don't emit fileCreated when creating a directory
R241:8ba03c4166c5: [KNewFileMenu] Don't emit fileCreated when creating a directory
Summary

BUG: 403100

Test Plan

unit tests pass.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chinmoyr created this revision.Jan 11 2019, 4:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 11 2019, 4:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
chinmoyr requested review of this revision.Jan 11 2019, 4:15 PM
hein accepted this revision.Jan 11 2019, 4:20 PM
This revision is now accepted and ready to land.Jan 11 2019, 4:20 PM
ngraham accepted this revision.Jan 11 2019, 4:28 PM

Test still passes, creating new files and directories still works, conceptually makes sense, fixes 403100. Thanks for doing this @chinmoyr!

Closed by commit R241:28dacfe07375: [KNewFileMenu] Don't emit fileCreated when creating a directory (authored by chinmoyr). · Explain WhyJan 11 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.
dfaure added a comment.Jan 11 2019, 4:52 PM

A unittest for this fix would have been even better ;)

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/knewfilemenu.cpp (30 lines)

Diff 49254

View Options

src/filewidgets/knewfilemenu.cpp

Loading...