KEncodingProber: Delete copy constructor and assignment operator
ClosedPublic

Authored by aacid on Wed, Jan 9, 8:43 PM.

Details

Summary

If someone was using them, it'd crash since it was raw-copying the d pointer
so you would end up with a double delete.

This is BIC, but IMHO it's fine, whoever gets a compiler failure has a bug to fix

Diff Detail

Repository
R270 KCodecs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Wed, Jan 9, 8:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Jan 9, 8:43 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Wed, Jan 9, 8:43 PM
vkrause added a subscriber: vkrause.Wed, Jan 9, 8:55 PM

As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree with Albert's reasoning for this change (and same for D18135).

apol added a subscriber: apol.Wed, Jan 9, 11:58 PM

As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree with Albert's reasoning for this change (and same for D18135).

that's what I thought when I saw the other patch.

vkrause accepted this revision.Thu, Jan 10, 7:40 PM
This revision is now accepted and ready to land.Thu, Jan 10, 7:40 PM
This revision was automatically updated to reflect the committed changes.