Request the resize of ShellSurface after Decoration updated the borders when maximizing
ClosedPublic
Actions

Authored by graesslin on Jun 9 2016, 2:53 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

Summary

This ensures that we don't send a size request with the borders still
added.

Test Plan

Verified that a maximized window is properly sized and
doesn't have empty borders

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to Request the resize of ShellSurface after Decoration updated the borders when maximizing.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

luebking added inline comments.

shell_client.cpp
595	ifff geometry() includes the deco for the ShellClient, this will get it shrinking away on each max/restore cycle. (If it's only the client geo, there's no problem)

shell_client.cpp
595	I actually tested that manually and it does not result in shrinking.

Looks good to me.

This revision is now accepted and ready to land.Jun 13 2016, 9:17 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/wayland/maximize_test.cpp (16 lines)
M			shell_client.cpp (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4311	04c3998		Jun 9 2016, 2:53 PM	★	★
Diff 2	4430	c7828ea	rKWIN53a3740082d0e5c50a9f539f0a307e02ca6ab3ad	Jun 14 2016, 5:39 AM	★	★