Differential D17984

Fix emmet script by using HEX instead of OCT numbers in strings
ClosedPublic
Actions

Authored by dhaumann on Jan 5 2019, 10:46 AM.

Details

Reviewers
carewolf
loh.tar
Commits
R39:2f467b46ac6f: Fix emmet script by using HEX instead of OCT numbers in strings
Summary

This is a follow-up commit to D17970, which did not yet fix it correctly.
The fix now is to use HEX notation instead of OCTAL notation, since
the OCTAL notation seems to not be supported by QML/V4 (which is likely
a bug).

BUG: 386151

Test Plan

Scripts in Tools > Scripts > Emmet work

Diff Detail

Repository
R39 KTextEditor
Branch
fix-emmet
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6664
Build 6682: arc lint + arc unit
dhaumann created this revision.Jan 5 2019, 10:46 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 5 2019, 10:46 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Jan 5 2019, 10:46 AM
carewolf accepted this revision.Jan 5 2019, 10:48 AM

Looks good to me

This revision is now accepted and ready to land.Jan 5 2019, 10:48 AM
Closed by commit R39:2f467b46ac6f: Fix emmet script by using HEX instead of OCT numbers in strings (authored by dhaumann). · Explain WhyJan 5 2019, 10:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48724

View Options

src/script/data/libraries/emmet/lib.js

Loading...