Added “modeCmdPart” to “redshiftOneTimeCommand”
Needs ReviewPublic

Authored by kvanton on Jan 4 2019, 12:59 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature.This is important, for example, when you need to manually adjust the...

Test Plan

Manual adjust Brightness and/or Temperature using custom mode options (redshift -m METHOD...)

Diff Detail

Repository
R885 Redshift Control for Plasma
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6633
Build 6651: arc lint + arc unit
kvanton created this revision.Jan 4 2019, 12:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2019, 12:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kvanton requested review of this revision.Jan 4 2019, 12:59 PM
kvanton retitled this revision from Added “modeCmdPart” to “redshiftOneTimeCommand”. This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature. This is important, for example, when you need to manually adjust the... to Added “modeCmdPart” to “redshiftOneTimeCommand”.This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature.This is important, for example, when you need to manually adjust the....Jan 4 2019, 1:01 PM
kvanton added a reviewer: Plasma.
nicolasfella retitled this revision from Added “modeCmdPart” to “redshiftOneTimeCommand”.This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature.This is important, for example, when you need to manually adjust the... to Added “modeCmdPart” to “redshiftOneTimeCommand”.Jan 4 2019, 1:02 PM
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella edited the test plan for this revision. (Show Details)

Seems sensible. I don't maintain the stuff in playground, but no-one really does.

If there's no comment in a week, ship it!

Do you have commit access?

Seems sensible. I don't maintain the stuff in playground, but no-one really does.

If there's no comment in a week, ship it!

Do you have commit access?

Sorry, this is my first time. How can I check access to a commit before doing it?

Sorry, this is my first time. How can I check access to a commit before doing it?

Congrats on your first patch. I'll sort it out.