Differential D17960

Added “modeCmdPart” to “redshiftOneTimeCommand”
Needs ReviewPublic
Actions

Authored by kvanton on Jan 4 2019, 12:59 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature.This is important, for example, when you need to manually adjust the...

Test Plan

Manual adjust Brightness and/or Temperature using custom mode options (redshift -m METHOD...)

Diff Detail

Repository
R885 Redshift Control for Plasma
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6633
Build 6651: arc lint + arc unit
kvanton created this revision.Jan 4 2019, 12:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2019, 12:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kvanton requested review of this revision.Jan 4 2019, 12:59 PM
kvanton retitled this revision from Added “modeCmdPart” to “redshiftOneTimeCommand”. This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature. This is important, for example, when you need to manually adjust the... to Added “modeCmdPart” to “redshiftOneTimeCommand”.This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature.This is important, for example, when you need to manually adjust the....Jan 4 2019, 1:01 PM
kvanton added a reviewer: Plasma.
nicolasfella retitled this revision from Added “modeCmdPart” to “redshiftOneTimeCommand”.This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature.This is important, for example, when you need to manually adjust the... to Added “modeCmdPart” to “redshiftOneTimeCommand”.Jan 4 2019, 1:02 PM
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella edited the test plan for this revision. (Show Details)
davidedmundson added a subscriber: davidedmundson.Jan 4 2019, 1:16 PM

Seems sensible. I don't maintain the stuff in playground, but no-one really does.

If there's no comment in a week, ship it!

Do you have commit access?

kvanton added a comment.Jan 4 2019, 2:08 PM
In D17960#386323, @davidedmundson wrote:

Seems sensible. I don't maintain the stuff in playground, but no-one really does.

If there's no comment in a week, ship it!

Do you have commit access?

Sorry, this is my first time. How can I check access to a commit before doing it?

davidedmundson added a comment.Jan 5 2019, 2:45 PM

Sorry, this is my first time. How can I check access to a commit before doing it?

Congrats on your first patch. I'll sort it out.

ltoscano added a subscriber: ltoscano.Oct 6 2019, 1:11 PM

@davidedmundson time to commit? :)

On a related news: I think it would make sense to create a new point release for plasma-redshift-control after this patch (there are many translation updates). Who could check that everything is in order and create the tarball?

kvanton added a comment.Jun 10 2020, 6:28 PM
In D17960#386905, @davidedmundson wrote:

Sorry, this is my first time. How can I check access to a commit before doing it?

Congrats on your first patch. I'll sort it out.

Of course, I still love and respect you, friend.
I still find this feature useful.
This allows you to independently adjust the temperature and brightness on different monitors. (it's still not possible without redshift)
Yes, I do not have access to commits

davidedmundson added a comment.Jun 11 2020, 9:31 AM

Sorry! pushed.

Please do feel free to nag if I forget things.

Revision Contents
Changeset List

PathPackages
Mpackage/contents/ui/main.qml (2 lines)

Diff 48667

View Options

package/contents/ui/main.qml

Loading...