This patch vertically centers the information label (infolabel) that appears once a user hovers/runs over their username with their mouse as well as increases its opacity in favor of better readability.
- Group Reviewers
- R119:510c88f65b76: [Kickoff] Increase Kickoff information label readability
Before and after
The opacity change makes sense to me: since this text isn't visible by default, there's no reason to make it difficult to read with a low opacity. If you go hunting for it and want to see it, you want it to be readable!
The alignment change I'm not as sure about. Because the username and information label are different sizes, I deliberately used bottom alignment to avoid having the system information label appear to jump up when hovering on it. With your change, the jumpiness is re-introduced:
What do you think of having this combination;
USERNAME (dev@pc, etc, etc, etc)
On mouseover, just make the rest of the description appear to the right of the username label INSTEAD of replacing the USERNAME label with the pc information. It will take a little bit more space but might seem more streamlined visually IMHO.
I tried that when I was redoing the header last time. It doesn't work because usernames, computer names, and operating system names can be very long, so in practice something is always elided.
I can understand that. Are users able to copy the information that displays on hover? If so, that would be one way to get the information you need and at the same time not replace labels?
No, the information is not copyable. It could be selectable, which would make it copyable. But this would be a new feature that should go in a new patch. :) And I wouldn't want for this string to just be always elided.
If those are the constraints, we can keep it as you propose, I would only make the computer information a lighter gray, possibly the same size font as the username, and I would make the username label bold or a heavier font weight. Just so that users don't inadvertently hover and wonder where their username went since fonts look very similar.
It's already a light gray; this patch is proposing to make it the same color as other text.
That would require a change to the Heading items since we shouldn't be overriding weights here. E.g. with D17906
FWIW I would support that since I think bold text in headings is conceptually correct and looks good.