Differential D17881

Fix title update when changing active split view
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 30 2018, 11:37 PM.

Details

Reviewers
rizzitello
ngraham
Group Reviewers
Dolphin
Commits
R318:504db3f70262: Fix title update when changing active split view
Summary

The DolphinTabPage::activeViewUrlChanged signal triggers the title
update in DolphinMainWindow, which sets the new title from the
m_activeViewContainer instance.

This means we need to notify the main window that the active view
changed before telling it that the current url changed.

BUG: 402641
FIXED-IN: 18.12.1

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 30 2018, 11:37 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Dec 30 2018, 11:37 PM
rizzitello accepted this revision.Dec 31 2018, 1:51 AM
rizzitello added a subscriber: rizzitello.

This works!. I will drop my fix.

This revision is now accepted and ready to land.Dec 31 2018, 1:51 AM
ngraham accepted this revision.Dec 31 2018, 4:45 AM
Closed by commit R318:504db3f70262: Fix title update when changing active split view (authored by elvisangelaccio). · Explain WhyJan 5 2019, 4:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48748

View Options

src/dolphintabpage.cpp

Loading...
View Options

src/tests/dolphinmainwindowtest.cpp

Loading...