Update window title on split toggle.
AbandonedPublic

Authored by rizzitello on Dec 28 2018, 6:24 PM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Summary

Updates the window title when a split is toggled.

BUG: 402641

Diff Detail

Repository
R318 Dolphin
Branch
fixSplitTitle
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6424
Build 6442: arc lint + arc unit
rizzitello created this revision.Dec 28 2018, 6:24 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 28 2018, 6:24 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
rizzitello requested review of this revision.Dec 28 2018, 6:24 PM
rizzitello edited the summary of this revision. (Show Details)Dec 28 2018, 6:28 PM
rizzitello edited the summary of this revision. (Show Details)
rizzitello edited the summary of this revision. (Show Details)
rizzitello edited the summary of this revision. (Show Details)
rizzitello edited the summary of this revision. (Show Details)Dec 28 2018, 6:30 PM
ngraham edited the summary of this revision. (Show Details)Dec 28 2018, 6:42 PM
ngraham requested changes to this revision.Dec 28 2018, 7:05 PM
ngraham added a subscriber: ngraham.

This fixes the issue described in the bug, but now the window title is wrong when you switch between split views; each view gets the other's title!

This revision now requires changes to proceed.Dec 28 2018, 7:05 PM
rizzitello updated this revision to Diff 48302.Dec 28 2018, 7:08 PM

Move update to view change

rizzitello updated this revision to Diff 48303.Dec 28 2018, 7:11 PM

Move update line so its with other update calls in the function

ngraham accepted this revision.Dec 28 2018, 7:14 PM

Much better, now it works, and I didn't detect any regressions.

Please wait for @elvisangelaccio's review before landing.

This revision is now accepted and ready to land.Dec 28 2018, 7:14 PM
rizzitello updated this revision to Diff 48304.Dec 28 2018, 7:25 PM

Rebase to stable

rizzitello updated this revision to Diff 48305.Dec 28 2018, 7:29 PM

Fix rebase

rizzitello updated this revision to Diff 48308.Dec 28 2018, 7:33 PM
  • re-reBase
rizzitello updated this revision to Diff 48310.Dec 28 2018, 7:40 PM
  • Rebase corectly this time
elvisangelaccio requested changes to this revision.Dec 30 2018, 11:17 PM

Sorry but this is a workaround: we already update the window title when the current URL changes. The problem is that when we do that, the DolphinMainWindow has not updated yet its reference to the active view container.

With this patch we would end up updating the window title twice, the first time with the old (wrong) title from the no longer active view.

This revision now requires changes to proceed.Dec 30 2018, 11:17 PM
rizzitello abandoned this revision.Dec 31 2018, 2:10 AM

Aborted in favor of D17881