Build without D-Bus on Android
ClosedPublic

Authored by vkrause on Dec 27 2018, 12:44 PM.

Details

Summary

This is probably the most invasive part of the Android support,
the remainder is implementing the native Android backend.

This will mean that KF5::Notifications will miss some API on Android
that depends on D-Bus, but with D-Bus not only being non-functional but
usually not even available as a stub I don't really see how to avoid that.

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Dec 27 2018, 12:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 27 2018, 12:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Dec 27 2018, 12:44 PM
vkrause updated this revision to Diff 48282.Dec 28 2018, 1:22 PM

Remove accidentally added block that is not supposed to be part of this commit.

+1, although it will likely break quickly since this branch is not tested via CI. Then again, this is also vslid for e.g. the KSyntaxHighlighting branches that were added for standalone deployment.

Another +1 would be appreciated.

+1, although it will likely break quickly since this branch is not tested via CI. Then again, this is also vslid for e.g. the KSyntaxHighlighting branches that were added for standalone deployment.

At least the binary factory build for KDE Itinerary should be testing this configuration. And AFAIK there are also some KF5 Android builds on the CI.

apol added a subscriber: apol.Dec 30 2018, 3:45 AM

+1, although it will likely break quickly since this branch is not tested via CI. Then again, this is also vslid for e.g. the KSyntaxHighlighting branches that were added for standalone deployment.

At least the binary factory build for KDE Itinerary should be testing this configuration. And AFAIK there are also some KF5 Android builds on the CI.

There should be CI, but I don't see knotifications:
https://build.kde.org/search/?q=android

CD will definitely be building it.

Android CI builds are only enabled for the following repositories:

- "frameworks/extra-cmake-modules"
- "frameworks/karchive"
- "frameworks/attica"
- "frameworks/breeze-icons"
- "frameworks/kcodecs"
- "frameworks/kconfig"
- "frameworks/kcoreaddons"
- "frameworks/kguiaddons"
- "frameworks/kconfig"
- "frameworks/ki18n"
- "frameworks/kirigami"
- "frameworks/kwidgetsaddons"
- "frameworks/threadweaver"
- "frameworks/kpackage"
- "frameworks/kunitconversion"
- "frameworks/kimageformats"
- "frameworks/kjobwidgets"
- "frameworks/kcompletion"
- "frameworks/prison"

Many of these were added in a660dffb and 2e5740a7 back in 2017.

D17868 adds kwindowsystem to the Android CI, which is (still) a dependency for knotifications, I'll add knotifications itself too once the necessary patches have landed.

dhaumann accepted this revision.Dec 30 2018, 1:07 PM

Given the discussion I think this should go in.

This revision is now accepted and ready to land.Dec 30 2018, 1:07 PM
This revision was automatically updated to reflect the committed changes.