| hindenburg |
| Konsole |
Fix crash when doing word selection or line selection
and moving the cursor to the end of the screen.
After 4e09f089f940335bdd628139e870ba99721fddfa
Konsole tries to read out of bounds when you double
click to select a whole empty line, and hold down the
mouse button and drag to the right.
Note: still crashes with on some extendSelections
such when y=-1
BUG: 402452
Doesn't crash anymore, selecting the last column works,
both in normal selection, line selection and word selection.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I can still get crashes extending selections
#4 0x00007ffff78b95e1 in Konsole::TerminalDisplay::loc (this=0x7120b0, x=42,
y=-1) at /home/kurthindenburg/Devel/KDE/src/kde/applications/konsole/src/TerminalDisplay.cpp:86
86 Q_ASSERT(y >= 0 && y < _lines);
(gdb) p _lines
$1 = 24
All right, full bounds check it is. I could also reproduce y=-1 for the resized window with overscroll (wasn't resizing the window earlier).
Should work properly now if I determined the cause correctly.
Seems safe enough. It would just make debug build behave like the release one because of the same transformations made in loc() after asserts.
The y=-1 issue is probably caused by the same selection-to-coords transformation.
This patch caused a critical regression on the stable branch: https://bugs.kde.org/show_bug.cgi?id=403117. This issue is affecting users on rolling release distros with KDE Applications 18.12.1.
I have reverted this patch on both the stable branch and master. Please feel free to give it another try, but this time please add an autotest for the failure condition in 403117 so we can make sure it doesn't regress again. Thanks!
A crash is better than a wrong selection ?
Em seg, 21 de jan de 2019 às 21:05, Nathaniel Graham <
noreply@phabricator.kde.org> escreveu:
ngraham reopened this revision.
ngraham added a comment.
This revision is now accepted and ready to land. View Revision
https://phabricator.kde.org/D17757This patch caused a critical regression on the stable branch:
https://bugs.kde.org/show_bug.cgi?id=403117. This issue is affecting
users on rolling release distros with KDE Applications 18.12.1.I have reverted this patch on both the stable branch and master. Please
feel free to give it another try, but this time please add an autotest for
the failure condition in 403117 so we can make sure it doesn't regress
again. Thanks!*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D17757*To: *pavelkh, Konsole, hindenburg
*Cc: *ngraham, konsole-devel, thsurrel, maximilianocuria, hindenburg
Can't break a feature in a minor version (.0 -> .1) on the stable branch. That's why we have stable branches. Let's focus on fixing the crash without regressing anything for 18.12.2.
It's ok that the change won't land in prod: release build doesn't have the crash, since it comes from Q_ASSERT, after which the value is properly clamped.
Abandoning this revision to avoid conflicts with Martin Sandsmark's branch that's actively worked on.
You'll need to formally Abandon it using the Add Action... combobox that's above the comment field.