pavelkh (Pavel Khlebovich)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 24 2018, 1:53 PM (42 w, 3 d)
Availability
Available

Recent Activity

Jan 23 2019

pavelkh abandoned D17757: Fix crash in extendSelection.

Thanks for the help! Didn't find the proper way of doing it with Ctrl+F.

Jan 23 2019, 10:48 PM · Konsole
pavelkh added a comment to D17757: Fix crash in extendSelection.

It's ok that the change won't land in prod: release build doesn't have the crash, since it comes from Q_ASSERT, after which the value is properly clamped.

Jan 23 2019, 9:03 PM · Konsole

Dec 29 2018

pavelkh added a comment to D17757: Fix crash in extendSelection.

Seems safe enough. It would just make debug build behave like the release one because of the same transformations made in loc() after asserts.

Dec 29 2018, 12:36 PM · Konsole

Dec 23 2018

pavelkh updated the diff for D17757: Fix crash in extendSelection.

All right, full bounds check it is. I could also reproduce y=-1 for the resized window with overscroll (wasn't resizing the window earlier).

Dec 23 2018, 6:50 PM · Konsole
pavelkh added a comment to D17740: Fix crash in extendSelection.

Couldn't update the diff in this ticket. The corrected version is at https://phabricator.kde.org/D17757

Dec 23 2018, 1:41 PM · Konsole
pavelkh requested review of D17757: Fix crash in extendSelection.
Dec 23 2018, 1:36 PM · Konsole
pavelkh added a comment to D17740: Fix crash in extendSelection.

This happens because loc() expects character-space indices, while selection-space indices are provided. The semantic of selection-space is that the index of the character after the last one select the last character.

Dec 23 2018, 1:34 PM · Konsole

Oct 22 2018

pavelkh added a comment to D16159: Fix double click can only select text within visible region.

@hindenburg it's pas.anddev@gmail.com.

Oct 22 2018, 9:39 AM · Konsole

Oct 12 2018

pavelkh requested review of D16159: Fix double click can only select text within visible region.
Oct 12 2018, 3:57 PM · Konsole

Sep 24 2018

pavelkh added a reviewer for D15732: Ignore default null eol in Session::sendTextToTerminal: Konsole.
Sep 24 2018, 2:28 PM · Konsole
pavelkh requested review of D15732: Ignore default null eol in Session::sendTextToTerminal.
Sep 24 2018, 2:22 PM · Konsole