Use qobject_cast instead of dynamic_cast
ClosedPublic
Actions

Authored by broulik on Dec 19 2018, 9:27 AM.

Details

Reviewers

Commits

R241:1d8e4e6fa29c: Use qobject_cast instead of dynamic_cast

Summary

Since KJob is a QObject we can use the more efficient qobject_cast here

Test Plan

Copied 1000 files, saved half a millisecond in addSubjob alone

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Dec 19 2018, 9:27 AM

broulik edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Dec 19 2018, 9:56 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/core/copyjob.cpp (4 lines)
M			src/core/job.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47824			Dec 19 2018, 9:26 AM	★	★
Diff 2	47834	e523ced	R241:1d8e4e6fa29c73931727b7888442fc9ad8d6ede7	Dec 19 2018, 9:57 AM	★	★