Add option to hide the title bar and frame off by default. The
window can be managed via tilling management and
alt+mouse hold, etc. This is not a normal workflow for a normal
user for a normal application, but is indeed used for power users.
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:20debf4815ab: MainWindow: Add Frameless option
Diff Detail
- Repository
- R319 Konsole
- Branch
- correction
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6092 Build 6110: arc lint + arc unit
@hindenburg @tcanabrava this PR is ready to review.
There is a problem with visibility if the windows is in a "opening state" when it's starting.
This only happens if I call show() or setVisibility(true) when the application is not visible yet.
That's why we have oldVisibility variable in this PR.
I think it looks good, just some trivial comments so I can show that I actually read the code.
story of my life.
src/settings/GeneralSettings.ui | ||
---|---|---|
193 | I assume all these random changes are from qt designer? this is why I usually just edit the XML by hand (and why I don't like .ui files anymore). | |
src/settings/konsole.kcfg | ||
15 | maybe «Don't show the normal titlebar and window frame» or something so the tooltip is actually different. or just remove the tooltip, I'm not sure if it helps anything here. |
What's the reason for this? Do other KDE apps have this option?
Also can you rebase this off recent master.
@sandsmark Corrections done.
@hindenburg, this is usually a common option for terminals. I know that such thing should be done in the window manager, but there is some WM that does not filter the frame for each application (line muffin and others).
The window can be managed via tilling management and alt+mouse hold and things like that, this is not a normal workflow for a normal user for a normal application, but is indeed used for the people that loves terminals, tmux, splits and etc.
OK, I don't see any major issues - on Wayland, with this option enabled, you can't move the window - I'm assuming that's a Wayland issue.
src/MainWindow.cpp | ||
---|---|---|
833 ↗ | (On Diff #47597) | while this works for bool, I'd rather use && here - I'll commit some changes after this. |