MainWindow: Add Frameless option

Authored by patrickelectric on Dec 14 2018, 10:08 PM.



Add option to hide the title bar and frame off by default. The
window can be managed via tilling management and
alt+mouse hold, etc. This is not a normal workflow for a normal
user for a normal application, but is indeed used for power users.

Diff Detail

R319 Konsole
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Konsole. · View Herald TranscriptDec 14 2018, 10:08 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
patrickelectric requested review of this revision.Dec 14 2018, 10:08 PM

remove debug message

You missed the kconfigxt configuration and the settings page.

Try to make Tomaz happy

patrickelectric added a comment.EditedDec 16 2018, 9:56 PM

@hindenburg @tcanabrava this PR is ready to review.
There is a problem with visibility if the windows is in a "opening state" when it's starting.

This only happens if I call show() or setVisibility(true) when the application is not visible yet.
That's why we have oldVisibility variable in this PR.

@hindenburg can you take a look ?

Yes, I'll try to look at this week - thanks.

I think it looks good, just some trivial comments so I can show that I actually read the code.

Try to make Tomaz happy

story of my life.


I assume all these random changes are from qt designer?

this is why I usually just edit the XML by hand (and why I don't like .ui files anymore).


maybe «Don't show the normal titlebar and window frame» or something so the tooltip is actually different. or just remove the tooltip, I'm not sure if it helps anything here.

What's the reason for this? Do other KDE apps have this option?

Also can you rebase this off recent master.

Add ui correction and remove tooltip

patrickelectric marked 2 inline comments as done.Dec 28 2018, 3:54 PM

@sandsmark Corrections done.

@hindenburg, this is usually a common option for terminals. I know that such thing should be done in the window manager, but there is some WM that does not filter the frame for each application (line muffin and others).
The window can be managed via tilling management and alt+mouse hold and things like that, this is not a normal workflow for a normal user for a normal application, but is indeed used for the people that loves terminals, tmux, splits and etc.

hindenburg accepted this revision.Dec 29 2018, 10:21 PM

OK, I don't see any major issues - on Wayland, with this option enabled, you can't move the window - I'm assuming that's a Wayland issue.

This revision is now accepted and ready to land.Dec 29 2018, 10:21 PM
hindenburg retitled this revision from MainWindow: Add Frameless configuration to MainWindow: Add Frameless option.Dec 29 2018, 10:34 PM
hindenburg edited the summary of this revision. (Show Details)
hindenburg added inline comments.Dec 29 2018, 10:38 PM

while this works for bool, I'd rather use && here - I'll commit some changes after this.

This revision was automatically updated to reflect the committed changes.