Differential D17550

Make the open url in tab feature a bit more discoverable
ClosedPublic
Actions

Authored by apol on Dec 13 2018, 1:28 AM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
Frameworks
Commits
R241:e523cedb0748: Make the open url in tab feature a bit more discoverable
Summary

Introduce a context menu item that invites to open the button under the menu in a tab.
It used to just work with the middle button, now it works with control+click as well, much like in web browsers.

BUG: 402073

Diff Detail

Repository
R241 KIO
Branch
arcpatch-D17550
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6097
Build 6115: arc lint + arc unit
apol created this revision.Dec 13 2018, 1:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 13 2018, 1:28 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Dec 13 2018, 1:28 AM
ngraham accepted this revision as: ngraham.Dec 13 2018, 5:12 AM

+1 for the idea and the UX as texted. No comment on the code change; I'm definitely not smart enough to understand it all!

This revision is now accepted and ready to land.Dec 13 2018, 5:12 AM
elvisangelaccio added a subscriber: elvisangelaccio.Dec 16 2018, 11:26 AM
elvisangelaccio added inline comments.
src/filewidgets/kurlnavigator.cpp
480 ↗(On Diff #47481)

Space after for

483 ↗(On Diff #47481)

Do we really have to put the folder name in the extry text? This will make the popup menu very large if the folder name is long.

apol marked an inline comment as done.Dec 17 2018, 1:32 AM
apol added inline comments.
src/filewidgets/kurlnavigator.cpp
483 ↗(On Diff #47481)

My thinking was that it's the only action that is context-dependent it better be explicit.

apol updated this revision to Diff 47705.Dec 17 2018, 1:32 AM

add space

apol updated this revision to Diff 47706.Dec 17 2018, 1:33 AM

Remove unrelated change

elvisangelaccio accepted this revision.Dec 17 2018, 9:31 PM
apol closed this revision.Dec 18 2018, 2:41 AM

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/kurlnavigator.cpp (32 lines)

Diff 47705

View Options

src/filewidgets/kurlnavigator.cpp

Loading...