Make the open url in tab feature a bit more discoverable
ClosedPublic
Actions

Authored by apol on Dec 13 2018, 1:28 AM.

Details

Reviewers

ngraham
elvisangelaccio

Group Reviewers

Dolphin
Frameworks

Commits

R241:e523cedb0748: Make the open url in tab feature a bit more discoverable

Summary

Introduce a context menu item that invites to open the button under the menu in a tab.
It used to just work with the middle button, now it works with control+click as well, much like in web browsers.

BUG: 402073

Diff Detail

Repository

R241 KIO

Branch

arcpatch-D17550

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6098
Build 6116: arc lint + arc unit

apol created this revision.Dec 13 2018, 1:28 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptDec 13 2018, 1:28 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

apol requested review of this revision.Dec 13 2018, 1:28 AM

Harbormaster completed remote builds in B5974: Diff 47481.Dec 13 2018, 1:28 AM

apol added a reviewer: Frameworks.Dec 13 2018, 1:28 AM

+1 for the idea and the UX as texted. No comment on the code change; I'm definitely not smart enough to understand it all!

This revision is now accepted and ready to land.Dec 13 2018, 5:12 AM

elvisangelaccio added a subscriber: elvisangelaccio.Dec 16 2018, 11:26 AM

elvisangelaccio added inline comments.

src/filewidgets/kurlnavigator.cpp
480	Space after `for`
483	Do we really have to put the folder name in the extry text? This will make the popup menu very large if the folder name is long.

apol marked an inline comment as done.Dec 17 2018, 1:32 AM

apol added inline comments.

src/filewidgets/kurlnavigator.cpp
483	My thinking was that it's the only action that is context-dependent it better be explicit.

add space

Harbormaster completed remote builds in B6097: Diff 47705.Dec 17 2018, 1:32 AM

Remove unrelated change

Harbormaster completed remote builds in B6098: Diff 47706.Dec 17 2018, 1:33 AM

elvisangelaccio accepted this revision.Dec 17 2018, 9:31 PM

apol closed this revision.Dec 18 2018, 2:41 AM

Revision Contents
Changeset List

			Path	Packages
M			src/filewidgets/kurlnavigator.h (4 lines)
M			src/filewidgets/kurlnavigator.cpp (32 lines)
M			src/filewidgets/kurlnavigatorbutton.cpp (8 lines)
M			src/filewidgets/kurlnavigatorbutton_p.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47481	5b68f5b		Dec 13 2018, 1:28 AM	★	★
Diff 2	47705	5b68f5b	add space	Dec 17 2018, 1:32 AM	★	★
Diff 3	47706	5b68f5b	Remove unrelated change	Dec 17 2018, 1:33 AM	★	★