Adapt favicon test to www.kde.org changes
AbandonedPublic

Authored by bruns on Dec 12 2018, 12:58 AM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Summary

The favicon test uses www.kde.org as a peer for testing. As a favicon.ico
has been added, the negative test no longer returns an error as expected.

Change the URL to some which will likely never succeed. Also change the
protocol to https, as non-existing URLs are redirected (302) before
failing (404).

Test Plan

run build/bin/favicontest

Diff Detail

Repository
R241 KIO
Branch
favicon_test
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5939
Build 5957: arc lint + arc unit
bruns created this revision.Dec 12 2018, 12:58 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 12 2018, 12:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Dec 12 2018, 12:58 AM
ngraham accepted this revision.Dec 12 2018, 4:22 AM
This revision is now accepted and ready to land.Dec 12 2018, 4:22 AM

I also thought the favicon was too large for FavIconJob to download

bruns added a comment.Dec 12 2018, 2:38 PM

I also thought the favicon was too large for FavIconJob to download

The now existing www.kde.org/favicon.ico ideed was to large for the favicon job, so the unchanged code got an "too large" error instead of the expected "does not exist". After pointing the job to a nonexisting file, this no longer is an issue.

bruns abandoned this revision.Feb 20 2019, 11:56 PM