Differential D1748

[KCM Keyboard] Delay initializing mouse
AbandonedPublic
Actions

Authored by broulik on Jun 2 2016, 4:05 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Calling kcminit mouse immediately when a new pointer device arrives does not work.
Adding a small delay until everything has settled makes it work. Just using a QuedConnection did not help

Test Plan

I can plug out and back in my mouse and it properly restores mouse settings for it.

(5.6 or master?)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 4167.Jun 2 2016, 4:05 PM
broulik retitled this revision from to [KCM Keyboard] Delay initializing mouse.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 2 2016, 4:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Jun 2 2016, 4:10 PM

Why doesn't it work immediately?

broulik added a comment.Jun 2 2016, 4:10 PM

I have no idea.

drosca added a subscriber: drosca.Jun 2 2016, 4:11 PM

I think this issue is only relevant when using UDev (udev_helper) for hot-plug detection instead of Xinput (xinput_helper), so I would prefer if the delay is used only in the udev case (and also for keyboard).

graesslin added a subscriber: graesslin.Jun 3 2016, 5:40 AM

Why is udev used here at all? On X11 we should use XInput, on Wayland hopefully nothing, because KWin takes care of it.

drosca added a comment.Jun 3 2016, 8:20 AM
In D1748#32567, @graesslin wrote:

Why is udev used here at all? On X11 we should use XInput, on Wayland hopefully nothing, because KWin takes care of it.

It is used only when xcb-xinput is not available (Debian/Ubuntu, ...).

graesslin added a comment.Jun 3 2016, 10:50 AM
In D1748#32573, @drosca wrote:
In D1748#32567, @graesslin wrote:

Why is udev used here at all? On X11 we should use XInput, on Wayland hopefully nothing, because KWin takes care of it.

It is used only when xcb-xinput is not available (Debian/Ubuntu, ...).

ah hum, that problem. In KWin and KScreenLocker the XLib based variant of XInput is used to solve that problem. Might be also an idea here.

broulik abandoned this revision.Jun 13 2016, 8:19 AM

Revision Contents
Changeset List

PathPackages
Mkcms/keyboard/keyboard_daemon.cpp (8 lines)

Diff 4167

View Options

kcms/keyboard/keyboard_daemon.cpp

Loading...