cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin
ClosedPublic

Authored by mpyne on Dec 9 2018, 3:57 AM.

Details

Summary

As reported in bug 401888, the current kcoreaddons_add_plugin CMake macro causes deprecation warnings in extra-cmake-module's KDEInstallDirs since we use an old-style install path variable (PLUGIN_INSTALL_DIR).

This should just be KDE_INSTALL_PLUGINDIR and so that's all my fix is, but since I'm not very familiar with the CMake stuff or the plugin loading code I wanted to get a review on it before I commit.

Test Plan

Built and installed kcoreaddons successfully, and then built and installed kactivitymanagerd (which uses kcoreaddons_add_plugin pervasively) and verified that kactivitymanagerd still builds and installs and that the plugin install dir, including its install namespace, is properly updated.

I also manually forced KDE_INSTALL_DIRS_NO_DEPRECATED to a true value in kactivitymanagerd as recommended in the bug, and still rebuilt/installed without deprecation warnings.

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mpyne created this revision.Dec 9 2018, 3:57 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 9 2018, 3:57 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mpyne requested review of this revision.Dec 9 2018, 3:57 AM
dfaure accepted this revision.Dec 9 2018, 10:34 AM
This revision is now accepted and ready to land.Dec 9 2018, 10:34 AM
elvisangelaccio accepted this revision.Dec 9 2018, 10:35 AM
This revision was automatically updated to reflect the committed changes.